GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-104146: Remove unused 'second_pass_replacements' from clinic.py by erlend-aasland · Pull Request #104147 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented May 3, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The code that manipulated 'second_pass_replacements' was removed in 2015 with commit 0759f84 (gh-67688, bpo-23500).

Issue:

  • Remove dead code from clinic.py #104146

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@erlend-aasland
erlend-aasland requested review from a team, corona10 and markshannon as code owners May 3, 2023 23:39
@erlend-aasland erlend-aasland added the skip news label May 3, 2023
@bedevere-bot bedevere-bot added the awaiting core review label May 3, 2023
@erlend-aasland
erlend-aasland removed request for a team, corona10 and markshannon May 3, 2023 23:40
@erlend-aasland
pythongh-104146: Remove unused 'second_pass_replacements' from clinic.py
396125f
The code that manipulated 'second_pass_replacements' was removed in 2015
with commit 0759f84 (pythongh-67688, bpo-23500).
@erlend-aasland
erlend-aasland force-pushed the clinic-remove-second-pass-replacements branch from 9768f7f to 396125f Compare May 3, 2023 23:41
@erlend-aasland erlend-aasland changed the title clinic remove second pass replacements gh-104146: Remove unused 'second_pass_replacements' from clinic.py May 3, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 3, 2023
Remove dead code from clinic.py #104146
Closed
@erlend-aasland erlend-aasland linked an issue May 3, 2023 that may be closed by this pull request
Remove dead code from clinic.py #104146
Closed
@erlend-aasland
erlend-aasland enabled auto-merge (squash) May 3, 2023 23:43
@erlend-aasland
erlend-aasland disabled auto-merge May 3, 2023 23:43
@erlend-aasland
erlend-aasland enabled auto-merge (squash) May 3, 2023 23:43
@erlend-aasland
erlend-aasland merged commit 9885677 into python:main May 4, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label May 4, 2023
@erlend-aasland
erlend-aasland deleted the clinic-remove-second-pass-replacements branch May 4, 2023 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove dead code from clinic.py

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@erlend-aasland @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.