GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-103801: Tools/wasm linting and formatting by dversoza · Pull Request #103796 · python/cpython

Conversation

@dversoza

@dversoza dversoza commented Apr 24, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This PR makes three minor linting adjustments to the wasm module caught by ruff.

  • Issue: Adjust Tools/wasm linting and formatting issues found by ruff #103801

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
dversoza added 3 commits April 24, 2023 15:34
@dversoza
Break line longer than 79 characters
56da814
@dversoza
Remove f-string without any placeholders
225266b
@dversoza
Rename unused local variable to _
e771641
@bedevere-bot

bedevere-bot commented Apr 24, 2023

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting review label Apr 24, 2023
@ghost

ghost commented Apr 24, 2023 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@blurb-it
📜🤖 Added by blurb_it.
ed7f29d
@bedevere-bot

bedevere-bot commented Apr 24, 2023

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@dversoza
Merge branch 'main' into wasm_linting_and_formatting
2e5da99
@bedevere-bot

bedevere-bot commented Apr 24, 2023

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@dversoza
Merge branch 'main' into wasm_linting_and_formatting
50a4c9b
@bedevere-bot

bedevere-bot commented Apr 24, 2023

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@dversoza
FIx NEWS filename generated by blurb_it.
940c069
@dversoza dversoza changed the title Tools/wasm linting and formatting gh-103796: Tools/wasm linting and formatting Apr 24, 2023
@dversoza dversoza changed the title gh-103796: Tools/wasm linting and formatting gh-103801: Tools/wasm linting and formatting Apr 24, 2023
@bedevere-bot bedevere-bot mentioned this pull request Apr 24, 2023
Adjust Tools/wasm linting and formatting issues found by ruff #103801
Closed
@dversoza
Fix NEWS filename generated by blurb_it.
adc0bab
@dversoza

dversoza commented Apr 24, 2023

Copy link
Copy Markdown
Contributor Author

@gpshead
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gpshead
gpshead approved these changes Apr 24, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Apr 24, 2023
@gpshead gpshead self-assigned this Apr 24, 2023
@gpshead
gpshead enabled auto-merge (squash) April 24, 2023 22:12
@gpshead
gpshead merged commit 01be52e into python:main Apr 24, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Apr 24, 2023
@dversoza
dversoza deleted the wasm_linting_and_formatting branch April 24, 2023 22:55
carljm added a commit to carljm/cpython that referenced this pull request Apr 24, 2023
@carljm
Merge branch 'main' into superopt_spec
3236f45 
* main:
  pythongh-103801: Tools/wasm linting and formatting (python#103796)
  pythongh-103673: Add missing ForkingUnixStreamServer and ForkingUnixDatagramServer socketservers (python#103674)
  pythongh-95795: Move types.next_version_tag to PyInterpreterState (pythongh-102343)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@gpshead gpshead

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@dversoza @bedevere-bot @gpshead
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.