GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-102950: Adjust tarfile filter tests for systems that don't set the sticky bit by encukou · Pull Request #103831 · python/cpython

Conversation

@encukou

@encukou encukou commented Apr 25, 2023

Copy link
Copy Markdown
Member

Also remove expilcit type=tarfile.DIRTYPE, the slash at the end is enough.

@kulikjak, could you check this on a Solaris or FreeBSD box?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
kulikjak reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@encukou
pythongh-102950: Adjust tests for systems that don't set the sticky bit
4ff2481 
Also remove expilcit `type=tarfile.DIRTYPE`, the slash at the end
is enough.
@encukou
encukou requested a review from ethanfurman as a code owner April 25, 2023 11:43
@encukou encukou changed the title gh-102950: Adjust tests for systems that don't set the sticky bit gh-102950: Adjust tarfile filter tests for systems that don't set the sticky bit Apr 25, 2023
@kulikjak

kulikjak commented Apr 25, 2023

Copy link
Copy Markdown
Contributor

I tried the patch on Solaris and the test suite is green again. Thanks!
encukou reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou encukou added the skip news label Apr 25, 2023
@encukou
Merge branch 'main' into tarfile-relax-t
ce74ead
@encukou
encukou enabled auto-merge (squash) April 25, 2023 12:29
@encukou encukou mentioned this pull request Apr 25, 2023
gh-102950: Implement PEP 706 – Filter for tarfile.extractall #102953
Merged
@encukou encukou added skip news skip issue and removed skip news labels Apr 25, 2023
@encukou
encukou merged commit c8c3956 into python:main Apr 25, 2023
@encukou encukou removed the skip issue label Apr 25, 2023
@encukou

encukou commented Apr 25, 2023

Copy link
Copy Markdown
Member Author

Hm, Sir Bedevere got stuck figuring out whether the pull request title starts with gh-####. Quite in character for a Monty Python character!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou
encukou deleted the tarfile-relax-t branch April 25, 2023 12:57
encukou added a commit to encukou/cpython that referenced this pull request Apr 25, 2023
@encukou
pythongh-102950: Adjust tarfile filter tests for systems that don't s…
ee503ad 
…et the sticky bit (pythonGH-103831)

Also remove expilcit `type=tarfile.DIRTYPE`, the slash at the end is
enough.

Backport of c8c3956
mcepl pushed a commit to openSUSE-Python/cpython that referenced this pull request May 3, 2023
@encukou @mcepl
pythongh-102950: Adjust tarfile filter tests for systems that don't s…
ae62b3a 
…et the sticky bit (pythonGH-103831)

Also remove expilcit `type=tarfile.DIRTYPE`, the slash at the end is
enough.

Backport of c8c3956
encukou added a commit to encukou/cpython that referenced this pull request May 11, 2023
@encukou
pythongh-102950: Adjust tarfile filter tests for systems that don't s…
15a108e 
…et the sticky bit (pythonGH-103831)

Also remove expilcit `type=tarfile.DIRTYPE`, the slash at the end is
enough.

Backport of c8c3956
encukou added a commit to encukou/cpython that referenced this pull request May 11, 2023
@encukou
pythongh-102950: Adjust tarfile filter tests for systems that don't s…
da07840 
…et the sticky bit (pythonGH-103831)

Also remove expilcit `type=tarfile.DIRTYPE`, the slash at the end is
enough.

Backport of c8c3956
encukou added a commit to encukou/cpython that referenced this pull request May 16, 2023
@encukou
pythongh-102950: Adjust tarfile filter tests for systems that don't s…
cabcaf2 
…et the sticky bit (pythonGH-103831)

Also remove expilcit `type=tarfile.DIRTYPE`, the slash at the end is
enough.

Backport of c8c3956
encukou added a commit to encukou/cpython that referenced this pull request May 30, 2023
@encukou
pythongh-102950: Adjust tarfile filter tests for systems that don't s…
46aab75 
…et the sticky bit (pythonGH-103831)

Also remove expilcit `type=tarfile.DIRTYPE`, the slash at the end is
enough.

Backport of c8c3956
mcepl pushed a commit to openSUSE-Python/cpython that referenced this pull request Mar 28, 2024
@encukou @mcepl
pythongh-102950: Adjust tarfile filter tests for systems that don't s…
ee1fab9 
…et the sticky bit (pythonGH-103831)

Also remove expilcit `type=tarfile.DIRTYPE`, the slash at the end is
enough.

Backport of c8c3956
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ethanfurman ethanfurman Awaiting requested review from ethanfurman ethanfurman is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@encukou @kulikjak
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.