GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-103583: Isolate CJK modules, alternative 3 by erlend-aasland · Pull Request #103870 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Apr 26, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Isolate _multibytecodec #103583

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland
WIP
3760032
@erlend-aasland
erlend-aasland requested a review from corona10 April 26, 2023 08:24
@bedevere-bot bedevere-bot mentioned this pull request Apr 26, 2023
Isolate _multibytecodec #103583
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Apr 26, 2023
@erlend-aasland erlend-aasland added the DO-NOT-MERGE label Apr 26, 2023
@erlend-aasland

erlend-aasland commented Apr 26, 2023

Copy link
Copy Markdown
Contributor Author

The approach I started on here is to pass the cjk module state to the cjk codec helpers, which means extensive changes in multibytecodec.c. IMO, this messes up the arg spec of the helpers too much, and I don't like the changes to _multibytecodec. I don't recommend this approach, but in theory it will work.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland closed this Apr 26, 2023
@erlend-aasland
erlend-aasland deleted the isolate-cjk-alt3 branch April 26, 2023 18:36
@erlend-aasland

erlend-aasland commented Apr 26, 2023

Copy link
Copy Markdown
Contributor Author

Closing in favour of #103869
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review DO-NOT-MERGE

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@erlend-aasland @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.