GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||
GeezerVison is showing github.com — gh-103583: Isolate CJK codec modules by erlend-aasland · Pull Request #103869 · python/cpython Conversation
|
|
This approach exploits the dependency introduced in gh-103589; we know for sure that the _codec* extension modules will outlive _multibytecodec. This means we can store the cjk codec module state safely in the codec struct and modify the various codec handlers to accept the codec struct (iso. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit ef983c4 🤖 If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
BTW, I removed the |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Also, we can split out cb2c9e7 as a separate PR. That may be beneficial regarding to future bisects; it will also make this PR easier to review. Similarly, f6ed5df can be split up to do the arg spec changes first, and then move stuff to module state afterwards. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@vstinner, you want to take a look? :) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@erlend-aasland I will take a look by tomorrow |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
(Pulling in main to get the latest ref. leak fixes by Jelle) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit dec79a7 🤖 If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
LGTM, This is quite a complicated but nice approach. But nothing can be better than this.
Thanks for the hard work!
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks for the review, Dong-hee! Yes, it is complicated, but as shown in my competing PRs, other approaches are even more complicated. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Well done @erlend-aasland! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Thanks, Victor :) This was a tricky one! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
Isolate _multibytecodec
There was an error while loading. Please reload this page.