GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||
GeezerVison is showing github.com — gh-103956: fix `trace` output in case of missing source line by chgnrdv · Pull Request #103958 · python/cpython Conversation
|
|
With this fix the output for frames with missing source files will look like this: |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Could you please add some tests?
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
It turned out that line tracing isn't tested at all. I will open a separate issue to handle it. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks @chgnrdv for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…ythonGH-103958) Print only filename with lineno if linecache.getline() returns an empty string. (cherry picked from commit 7c87ce7) Co-authored-by: Radislav Chugunov <[email protected]>
…ythonGH-103958) Print only filename with lineno if linecache.getline() returns an empty string. (cherry picked from commit 7c87ce7) Co-authored-by: Radislav Chugunov <[email protected]>
|
GH-118832 is a backport of this pull request to the 3.12 branch. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
GH-118833 is a backport of this pull request to the 3.11 branch. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks @chgnrdv for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…ythonGH-103958) Print only filename with lineno if linecache.getline() returns an empty string. (cherry picked from commit 7c87ce7) Co-authored-by: Radislav Chugunov <[email protected]>
|
GH-118834 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
It is too late for the 3.11 backport, but it should now be backported to 3.13. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…ythonGH-103958) Print only filename with lineno if linecache.getline() returns an empty string.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
trace: line tracing output lacks newlines if source lines are not available
There was an error while loading. Please reload this page.