GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-97950: Use new-style index directive ('module') by AA-Turner · Pull Request #103996 · python/cpython

Conversation

@AA-Turner

@AA-Turner AA-Turner commented Apr 29, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Docs use deprecated Sphinx .. index:: entries #97950

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
AA-Turner added 4 commits April 29, 2023 23:34
@AA-Turner
Use new-style index directive ('module') - C API
2527f9d
@AA-Turner
Use new-style index directive ('module') - Library
73f896f
@AA-Turner
Use new-style index directive ('module') - Reference
5079c27
@AA-Turner
Use new-style index directive ('module') - Tutorial
5f7fa3c
@AA-Turner AA-Turner added docs Documentation in the Doc dir skip news needs backport to 3.11 only security fixes labels Apr 29, 2023
@AA-Turner
AA-Turner requested review from CAM-Gerlach and hugovk April 29, 2023 22:37
@AA-Turner AA-Turner self-assigned this Apr 29, 2023
@bedevere-bot bedevere-bot mentioned this pull request Apr 29, 2023
Docs use deprecated Sphinx .. index:: entries #97950
Closed
@bedevere-bot bedevere-bot added the awaiting review label Apr 29, 2023
@AA-Turner
AA-Turner requested a review from ezio-melotti April 29, 2023 22:38
AA-Turner added 5 commits May 4, 2023 08:19
@AA-Turner
Merge branch 'main' into old-index-directives/module
f1c8dec
@AA-Turner
Uncomment module removal in pairindextypes
f1d3022
@AA-Turner
Use new-style index directive ('module') - C API
18cd4a1
@AA-Turner
Use new-style index directive ('module') - Library
1e6b157
@AA-Turner
Use new-style index directive ('module') - Reference
cc7c819
@AA-Turner
AA-Turner requested a review from tiran as a code owner May 4, 2023 07:26
@AA-Turner
AA-Turner removed the request for review from tiran May 4, 2023 07:27
hugovk
hugovk approved these changes May 4, 2023
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AA-Turner reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels May 4, 2023
ezio-melotti
ezio-melotti approved these changes May 4, 2023
View reviewed changes
@ezio-melotti
ezio-melotti merged commit d012237 into python:main May 4, 2023
@miss-islington

miss-islington commented May 4, 2023

Copy link
Copy Markdown
Contributor

Thanks @AA-Turner for the PR, and @ezio-melotti for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label May 4, 2023
@miss-islington

miss-islington commented May 4, 2023

Copy link
Copy Markdown
Contributor

Sorry, @AA-Turner and @ezio-melotti, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker d0122372f2acb4cc56b89ab8c577ff9039d17d89 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned ezio-melotti and unassigned AA-Turner May 4, 2023
@AA-Turner

AA-Turner commented May 4, 2023

Copy link
Copy Markdown
Member Author

I'm happy to handle the backport @ezio-melotti?

A
ezio-melotti reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AA-Turner added a commit to AA-Turner/cpython that referenced this pull request May 4, 2023
@AA-Turner
[3.11] pythonGH-97950: Use new-style index directive ('module') (pyth…
65361fb 
…onGH-103996)

* Use new-style index directive ('module') - C API

* Use new-style index directive ('module') - Library

* Use new-style index directive ('module') - Reference

* Use new-style index directive ('module') - Tutorial

* Uncomment module removal in pairindextypes

* Use new-style index directive ('module') - C API

* Use new-style index directive ('module') - Library

* Use new-style index directive ('module') - Reference.
(cherry picked from commit d012237)

Co-authored-by: Adam Turner <[email protected]>
@bedevere-bot

bedevere-bot commented May 4, 2023

Copy link
Copy Markdown

GH-104154 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label May 4, 2023
ezio-melotti pushed a commit to ezio-melotti/cpython that referenced this pull request May 4, 2023
@AA-Turner @ezio-melotti
pythonGH-97950: Use new-style index directive ('module') (python#103996)
8169725 
* Use new-style index directive ('module') - C API

* Use new-style index directive ('module') - Library

* Use new-style index directive ('module') - Reference

* Use new-style index directive ('module') - Tutorial

* Uncomment module removal in pairindextypes

* Use new-style index directive ('module') - C API

* Use new-style index directive ('module') - Library

* Use new-style index directive ('module') - Reference

(cherry picked from commit d012237)
hugovk pushed a commit that referenced this pull request May 4, 2023
@AA-Turner
[3.11] GH-97950: Use new-style index directive ('module') (GH-103996) (…
0056369 
…#104154)
@AA-Turner
AA-Turner deleted the old-index-directives/module branch May 4, 2023 10:20
@hugovk hugovk mentioned this pull request May 8, 2023
Unable to generate POT for Python documentation #104284
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes
@ezio-melotti ezio-melotti ezio-melotti approved these changes
@CAM-Gerlach CAM-Gerlach Awaiting requested review from CAM-Gerlach

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@ezio-melotti ezio-melotti

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@AA-Turner @miss-islington @bedevere-bot @hugovk @ezio-melotti
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.