GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-97950: Allow translation of index directive content by AA-Turner · Pull Request #104000 · python/cpython

Conversation

@AA-Turner

@AA-Turner AA-Turner commented Apr 29, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This comment, which eventually links to this comment point out that Sphinx's support for translating index directives isn't as straightfowards as it could be.

This PR is my best attempt at a workaround -- the reason for the commenting out is that there is a test to check if an entry of a pair directive is one of the already-translated pairindextypes values. As we intend to move away from this, we need Sphinx to believe that these values don't exist, by deleting them when using the gettext builder.

https://github.com/sphinx-doc/sphinx/blob/ba7408209e84ee413f240afc20f3c6b484a81f8f/sphinx/builders/gettext.py#L162-L165

A

  • Issue: Docs use deprecated Sphinx .. index:: entries #97950

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
AA-Turner added 3 commits April 29, 2023 23:47
@AA-Turner
Allow translating index directives
f4873ee
@AA-Turner
Clear pairindextypes entries
474108c
@AA-Turner
comment out removals
8d79707
@AA-Turner AA-Turner added docs Documentation in the Doc dir skip news needs backport to 3.11 only security fixes labels Apr 29, 2023
@AA-Turner
AA-Turner requested review from CAM-Gerlach, ezio-melotti and hugovk April 29, 2023 23:27
@AA-Turner AA-Turner self-assigned this Apr 29, 2023
@bedevere-bot bedevere-bot mentioned this pull request Apr 29, 2023
Docs use deprecated Sphinx .. index:: entries #97950
Closed
@bedevere-bot bedevere-bot added the awaiting review label Apr 29, 2023
ezio-melotti
ezio-melotti reviewed May 1, 2023
View reviewed changes
Comment thread Doc/tools/extensions/pyspecific.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
AA-Turner
AA-Turner commented May 1, 2023
View reviewed changes
Comment thread Doc/tools/extensions/pyspecific.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
AA-Turner and others added 2 commits May 1, 2023 07:35
@AA-Turner
Delete deletion
b90c593
@AA-Turner
syntax
3a7ac94
hugovk
hugovk reviewed May 2, 2023
View reviewed changes
Comment thread Doc/tools/extensions/pyspecific.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner
Add explanatory note
d575f69
@AA-Turner
AA-Turner requested review from ezio-melotti and hugovk May 3, 2023 12:22
ezio-melotti
ezio-melotti approved these changes May 3, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels May 3, 2023
hugovk
hugovk approved these changes May 3, 2023
View reviewed changes
@hugovk
hugovk merged commit 35d2738 into python:main May 4, 2023
@miss-islington

miss-islington commented May 4, 2023

Copy link
Copy Markdown
Contributor

Thanks @AA-Turner for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label May 4, 2023
@bedevere-bot

bedevere-bot commented May 4, 2023

Copy link
Copy Markdown

GH-104151 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label May 4, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 4, 2023
@AA-Turner @miss-islington
pythonGH-97950: Allow translation of index directive content (pythonG…
e2e4be8 
…H-104000)

(cherry picked from commit 35d2738)

Co-authored-by: Adam Turner <[email protected]>
@AA-Turner

AA-Turner commented May 4, 2023

Copy link
Copy Markdown
Member Author

Thanks Hugo!

A
hugovk reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hugovk pushed a commit that referenced this pull request May 4, 2023
@miss-islington @AA-Turner
[3.11] GH-97950: Allow translation of index directive content (GH-104000
8f94c94 
) (#104151)

Co-authored-by: Adam Turner <[email protected]>
@AA-Turner
AA-Turner deleted the old-index-directives/translate-index branch May 4, 2023 10:20
@rffontenelle rffontenelle mentioned this pull request May 8, 2023
Unable to generate POT for Python documentation #104284
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes
@ezio-melotti ezio-melotti ezio-melotti approved these changes
@CAM-Gerlach CAM-Gerlach Awaiting requested review from CAM-Gerlach

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@AA-Turner AA-Turner

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@AA-Turner @miss-islington @bedevere-bot @hugovk @ezio-melotti
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.