GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] gh-104035: Do not ignore user-defined `__{get,set}state__` in slotted frozen dataclasses (GH-104041) by miss-islington · Pull Request #104044 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented May 1, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit 99aab61)

Co-authored-by: Nikita Sobolev [email protected]

  • Issue: Frozen dataclasses with slots cannot override __getstate__ or __setstate__ #104035

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn @miss-islington
pythongh-104035: Do not ignore user-defined __{get,set}state__ in s…
9141fed 
…lotted frozen dataclasses (pythonGH-104041)

(cherry picked from commit 99aab61)

Co-authored-by: Nikita Sobolev <[email protected]>
@miss-islington
miss-islington requested a review from ericvsmith as a code owner May 1, 2023 15:19
@bedevere-bot bedevere-bot added the awaiting review label May 1, 2023
This was referenced May 1, 2023
Frozen dataclasses with slots cannot override __getstate__ or __setstate__ #104035
Closed
gh-104035: Do not ignore user-defined __{get,set}state__ in slotted frozen dataclasses #104041
Merged
carljm
carljm approved these changes May 1, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels May 1, 2023
@carljm carljm linked an issue May 1, 2023 that may be closed by this pull request
Frozen dataclasses with slots cannot override __getstate__ or __setstate__ #104035
Closed
@carljm
carljm merged commit 0df7c3a into python:3.11 May 1, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label May 1, 2023
@miss-islington
miss-islington deleted the backport-99aab61-3.11 branch May 1, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carljm carljm carljm approved these changes
@ericvsmith ericvsmith Awaiting requested review from ericvsmith ericvsmith is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Frozen dataclasses with slots cannot override __getstate__ or __setstate__

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @carljm @bedevere-bot @sobolevn
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.