GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-104035: Do not ignore user-defined `__{get,set}state__` in slotted frozen dataclasses by sobolevn · Pull Request #104041 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented May 1, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I had some time to look at this problem. Here's what I found:

  1. Our docs do not say anything about __getstate__ or __setstate__ methods and their generation: https://docs.python.org/3/library/dataclasses.html
  2. I think that this new implementation is in-line with other methods / attributes generation
  3. It should not break any existing code, except cases where some invalid __getstate__ / __setstate__ method was overridden with the correct one (but, there's nothing we can do if user already has invalid code)
  4. This seems like a bug-fix, so probably it should be back-ported to 3.11 as well
  • Issue: Frozen dataclasses with slots cannot override __getstate__ or __setstate__ #104035

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@sobolevn
pythongh-104035: Do not ignore user-defined __{get,set}state__ in s…
b6a09a4
…lotted frozen dataclasses
@sobolevn
sobolevn requested a review from ericvsmith as a code owner May 1, 2023 13:47
@bedevere-bot bedevere-bot added the awaiting review label May 1, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 1, 2023
Frozen dataclasses with slots cannot override __getstate__ or __setstate__ #104035
Closed
@sobolevn
Update 2023-05-01-16-43-28.gh-issue-104035.MrJBw8.rst
07d5b21
carljm
carljm approved these changes May 1, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels May 1, 2023
@carljm carljm added the needs backport to 3.11 only security fixes label May 1, 2023
@carljm
carljm merged commit 99aab61 into python:main May 1, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label May 1, 2023
@miss-islington

miss-islington commented May 1, 2023

Copy link
Copy Markdown
Contributor

Thanks @sobolevn for the PR, and @carljm for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot

bedevere-bot commented May 1, 2023

Copy link
Copy Markdown

GH-104044 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 1, 2023
@sobolevn @miss-islington
pythongh-104035: Do not ignore user-defined __{get,set}state__ in s…
9141fed
…lotted frozen dataclasses (pythonGH-104041)

(cherry picked from commit 99aab61)

Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label May 1, 2023
carljm pushed a commit that referenced this pull request May 1, 2023
@miss-islington @sobolevn
[3.11] gh-104035: Do not ignore user-defined __{get,set}state__ in …
0df7c3a
…slotted frozen dataclasses (GH-104041) (#104044)

gh-104035: Do not ignore user-defined `__{get,set}state__` in slotted frozen dataclasses (GH-104041)
(cherry picked from commit 99aab61)

Co-authored-by: Nikita Sobolev <[email protected]>
carljm added a commit to carljm/cpython that referenced this pull request May 1, 2023
@carljm
Merge branch 'main' into inlinecomp2
1274e2b
* main: (463 commits)
  pythongh-104057: Fix direct invocation of test_super (python#104064)
  pythongh-87092: Expose assembler to unit tests (python#103988)
  pythongh-97696: asyncio eager tasks factory (python#102853)
  pythongh-84436: Immortalize in _PyStructSequence_InitBuiltinWithFlags() (pythongh-104054)
  pythongh-104057: Fix direct invocation of test_module (pythonGH-104059)
  pythongh-100458: Clarify Enum.__format__() change of mixed-in types in the whatsnew/3.11.rst (pythonGH-100387)
  pythongh-104018: disallow "z" format specifier in %-format of byte strings (pythonGH-104033)
  pythongh-104016: Fixed off by 1 error in f string tokenizer (python#104047)
  pythonGH-103629: Update Unpack's repr in compliance with PEP 692 (python#104048)
  pythongh-102799: replace sys.exc_info by sys.exception in inspect and traceback modules (python#104032)
  Fix typo in "expected" word in few source files (python#104034)
  pythongh-103824: fix use-after-free error in Parser/tokenizer.c (python#103993)
  pythongh-104035: Do not ignore user-defined `__{get,set}state__` in slotted frozen dataclasses (python#104041)
  pythongh-104028: Reduce object creation while calling callback function from gc (pythongh-104030)
  pythongh-104036: Fix direct invocation of test_typing (python#104037)
  pythongh-102213: Optimize the performance of `__getattr__` (pythonGH-103761)
  pythongh-103895: Improve how invalid `Exception.__notes__` are displayed (python#103897)
  Adjust expression from `==` to `!=` in alignment with the meaning of the paragraph. (pythonGH-104021)
  pythongh-88496: Fix IDLE test hang on macOS (python#104025)
  Improve int test coverage (python#104024)
  ...
@DouweM DouweM mentioned this pull request Apr 25, 2025
Make sure Pydantic dataclasses with slots and validate_assignment can be unpickled pydantic/pydantic#11769
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carljm carljm carljm approved these changes
@ericvsmith ericvsmith Awaiting requested review from ericvsmith ericvsmith is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@sobolevn @miss-islington @bedevere-bot @carljm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.