GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-104057: Fix direct invocation of test_support by Eclips4 · Pull Request #104069 · python/cpython

Conversation

@Eclips4

@Eclips4 Eclips4 commented May 1, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member 
./python Lib/test/test_support.py
Running Debug|x64 interpreter...
.....................s.F......s.........s...
======================================================================
FAIL: test_ignored_deprecations_are_silent (__main__.TestSupport.test_ignored_deprecations_are_silent)
Test support.ignore_deprecations_from() silences warnings
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\Users\KIRILL-1\CLionProjects\cpython\Lib\test\test_support.py", line 52, in test_ignored_deprecations_are_silent       
    self.assertEqual(len(messages), 0, messages)
AssertionError: 1 != 0 : ['You should NOT be seeing this.']

----------------------------------------------------------------------
Ran 44 tests in 8.697s

FAILED (failures=1, skipped=3)

However, there's an another bug with test_make_bad_fd (only on Windows) but it's not related.

  • Issue: Some test modules fail when run as a script #104057

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Eclips4
pythongh-104057: Fix path
22c60b5
@bedevere-bot bedevere-bot added the awaiting review label May 1, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 1, 2023
Some test modules fail when run as a script #104057
Closed
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label May 1, 2023
@AlexWaygood AlexWaygood changed the title gh-104057: Fix direct invocatoin of test_support gh-104057: Fix direct invocation of test_support May 1, 2023
@AlexWaygood AlexWaygood added the skip news label May 1, 2023
furkanonder
furkanonder approved these changes May 2, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels May 2, 2023
@furkanonder

furkanonder commented May 2, 2023

Copy link
Copy Markdown
Contributor

LGTM.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zware
zware merged commit 27419a7 into python:main May 11, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label May 11, 2023
carljm added a commit to carljm/cpython that referenced this pull request May 11, 2023
@carljm
Merge branch 'main' into supermon
fb47955 
* main:
  pythongh-104057: Fix direct invocation of test_support (pythonGH-104069)
  pythongh-87729: improve hit rate of LOAD_SUPER_ATTR specialization (python#104270)
  pythongh-101819: Fix inverted debug preprocessor check in winconsoleio.c (python#104388)
@Eclips4
Eclips4 deleted the fix_test_support branch May 12, 2023 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@furkanonder furkanonder furkanonder approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@Eclips4 @furkanonder @zware @bedevere-bot @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.