GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] GH-103472: close response in HTTPConnection._tunnel (GH-103473) by miss-islington · Pull Request #104077 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented May 2, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Avoid a potential ResourceWarning in http.client.HTTPConnection
by closing the proxy / tunnel's CONNECT response explicitly.


(cherry picked from commit 9de0cf2)

Co-authored-by: Thomas Grainger [email protected]
Co-authored-by: Gregory P. Smith [email protected]

  • Issue: ResourceWarning due to unclosed response in http.client.HTTPConnection._tunnel #103472

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@graingert @gpshead @miss-islington
pythonGH-103472: close response in HTTPConnection._tunnel (pythonGH-1…
8f1ce8f
…03473)

Avoid a potential `ResourceWarning` in `http.client.HTTPConnection`
by closing the proxy / tunnel's CONNECT response explicitly.

---------

(cherry picked from commit 9de0cf2)

Co-authored-by: Thomas Grainger <[email protected]>
Co-authored-by: Gregory P. Smith <[email protected]>
@bedevere-bot bedevere-bot added the awaiting review label May 2, 2023
This was referenced May 2, 2023
ResourceWarning due to unclosed response in http.client.HTTPConnection._tunnel #103472
Closed
GH-103472: close response in HTTPConnection._tunnel #103473
Merged
gpshead
gpshead approved these changes May 2, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels May 2, 2023
@gpshead
gpshead merged commit 0d40264 into python:3.11 May 2, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label May 2, 2023
@miss-islington
miss-islington deleted the backport-9de0cf2-3.11 branch May 2, 2023 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @gpshead @bedevere-bot @graingert
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.