Description

graingert

opened on Apr 12, 2023

Issue body actions

Bug report

calling http.client.HTTPConnection._tunnel() may result in a ResourceWarning because the response is not closed

this results in an intermittent failure on the urllib3 test test/with_dummyserver/test_proxy_poolmanager.py::TestHTTPProxyManager::test_tunneling_proxy_request_timeout[https-https] with ResourceWarnings enabled, see https://github.com/urllib3/urllib3/actions/runs/4638944124/jobs/8209257011#step:6:2471 and https://github.com/urllib3/urllib3/blob/4d425a2d767ce2e0c988fff4385046ea57458c49/test/with_dummyserver/test_proxy_poolmanager.py#L480-L498

Your environment

• CPython versions tested on: 3.8-3.11

Linked PRs

• GH-103472: close response in HTTPConnection._tunnel #103473
• [3.11] GH-103472: close response in HTTPConnection._tunnel (GH-103473) #104077

Activity

1. graingert

   added

   type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

   stdlibStandard Library Python modules in the Lib/ directoryStandard Library Python modules in the Lib/ directory

   3.11only security fixesonly security fixes

   3.12only security fixesonly security fixes

   3.13only security fixesonly security fixes

   on Apr 12, 2023
2. graingert

   added a commit that references this issue on Apr 12, 2023

   pythonGH-103472: close response in HTTPConnection._tunnel

   86952ce
3. graingert

   changed the title [-]ResourceWarning due to unclosed request in http.client.HTTPConnection._tunnel[/-] [+]ResourceWarning due to unclosed response in http.client.HTTPConnection._tunnel[/+] on Apr 12, 2023
4. gpshead

   added a commit that references this issue on May 2, 2023

   GH-103472: close response in HTTPConnection._tunnel (#103473)

   9de0cf2
5. miss-islington

   added a commit that references this issue on May 2, 2023

   pythonGH-103472: close response in HTTPConnection._tunnel (pythonGH-1…

   8f1ce8f
6. gpshead

   added a commit that references this issue on May 2, 2023

   [3.11] GH-103472: close response in HTTPConnection._tunnel (GH-103473) (

   0d40264
7. carljm

   added 2 commits that reference this issue on May 2, 2023

   Merge branch 'main' into inlinecomp2

   0727d6f

   Merge branch 'main' into cached_property_docs

   b9c39e3
8. hauntsaninja commented on Sep 7, 2023

   

   hauntsaninja

   on Sep 7, 2023

   Contributor

   More actions

   Looks like this was fixed, thanks all!
9. hauntsaninja

   closed this as completedon Sep 7, 2023
10. netbsd-srcmastr

    added a commit that references this issue on Sep 12, 2024

    py-urllib3: updated to 2.2.3

    fefdfd3
11. apereocas-bot

    added a commit that references this issue on Sep 13, 2024

    renovatebot(deps): update dependency urllib3 to v2.2.3

    48755b4
12. lqiu96

    added a commit that references this issue on Sep 16, 2024

    deps: update dependency urllib3 to v2.2.3 (#3194)

    f69d511
13. ldetmer

    added a commit that references this issue on Sep 17, 2024

    deps: update dependency urllib3 to v2.2.3 (#3194)

    68c2731
14. bmwiedemann

    added a commit that references this issue on Oct 3, 2024

    Update python-urllib3 to version 2.2.3 / rev 68 via SR 1205339

    c834ec9
15. halstead

    added 3 commits that reference this issue on Dec 2, 2024

    python3-urllib3: upgrade 2.2.2 -> 2.2.3

    ceece31

    python3-urllib3: upgrade 2.2.2 -> 2.2.3

    39c4908

    python3-urllib3: upgrade 2.2.2 -> 2.2.3

    9333976
16. brainhoard-github

    added a commit that references this issue on Dec 3, 2024

    python3-urllib3: upgrade 2.2.2 -> 2.2.3

    e89a6fc
17. halstead

    added 2 commits that reference this issue on Dec 3, 2024

    python3-urllib3: upgrade 2.2.2 -> 2.2.3

    b15fc7c

    python3-urllib3: upgrade 2.2.2 -> 2.2.3

    61331e2
18. leimaohui

    added 2 commits that reference this issue on Dec 25, 2024

    python3-urllib3: upgrade 2.2.2 -> 2.2.3

    6615e74

    python3-urllib3: upgrade 2.2.2 -> 2.2.3

    ef9f484
19. msk

    added a commit that references this issue on May 11, 2026

    py-urllib3: updated to 2.2.3

    c7caf82
20. jperkin

    added a commit that references this issue on May 14, 2026

    py-urllib3: updated to 2.2.3

    abd2672
21. tsutsui

    added a commit that references this issue on Oct 17, 2026

    py-urllib3: updated to 2.2.3

    f4e10ba

Issue actions