GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.10] gh-102950: Implement PEP 706 – Filter for tarfile.extractall (GH-102953) by mcepl · Pull Request #104128 · python/cpython

Conversation

@mcepl

@mcepl mcepl commented May 3, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Manual port of gh-102953 to 3.10.

Please, review.

  • Issue: Implement PEP 706 – Filter for tarfile.extractall #102950

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@encukou @mcepl
Implement PEP 706 – Filter for tarfile.extractall
52dd746
@mcepl
mcepl requested a review from ethanfurman as a code owner May 3, 2023 11:28
This was referenced May 3, 2023
Implement PEP 706 – Filter for tarfile.extractall #102950
Closed
gh-102950: Implement PEP 706 – Filter for tarfile.extractall #102953
Merged
@bedevere-bot bedevere-bot added the awaiting review label May 3, 2023
@encukou

encukou commented May 3, 2023

Copy link
Copy Markdown
Member

Thanks for getting to this sooner than I did!
But see https://github.com/python/cpython/pull/103832/commits for the changes needed in the backport.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mcepl

mcepl commented May 3, 2023

Copy link
Copy Markdown
Contributor Author

I was basing it on this 3.11 PR, I know better than using master branch for this. But yes, I will re-check, that everything in that PR has been included.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@encukou

encukou commented May 3, 2023

Copy link
Copy Markdown
Member

Ah, sorry! I just looked at the versionchanged:: 3.12 and gave a quick comment. Will do a proper review later.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

encukou added 4 commits May 3, 2023 16:00
@encukou @mcepl
Adjust the docs for 3.10.12
10a05d8
@encukou @mcepl
Remove the DeprecationWarning
b2f7a44
@encukou @mcepl
Remove new __all__ entries
688286c
@encukou @mcepl
pythongh-102950: Adjust tarfile filter tests for systems that don't s…
ae62b3a
…et the sticky bit (pythonGH-103831)

Also remove expilcit `type=tarfile.DIRTYPE`, the slash at the end is
enough.

Backport of c8c3956
@mcepl

mcepl commented May 3, 2023

Copy link
Copy Markdown
Contributor Author

Yes, you were right, I missed those, not sure how I have managed to do that.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mcepl

mcepl commented May 3, 2023

Copy link
Copy Markdown
Contributor Author

I don't understand those Windows failures … shouldn’t it be covered by ae62b3a ?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

encukou
encukou reviewed May 4, 2023
View reviewed changes
Comment thread Doc/library/shutil.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

@encukou

encukou commented May 4, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

No. ae62b3a is for Solaris or BSD, supported platforms (per PEP 11) don't need it.

This change made me get a Windows VM, so I'll investigate there. Can't promise it'll be this week though.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mcepl
Fix version numbers in documentation.
abb0e84
@encukou encukou mentioned this pull request May 9, 2023
[3.10] gh-102950: Implement PEP 706 – Filter for tarfile.extractall (GH-102953) #104327
Closed
@encukou

encukou commented May 9, 2023

Copy link
Copy Markdown
Member

It's related to a change made while backporting, going from

        if mode is not None and os_helper.can_chmod():

to just

        if mode is not None:

The can_chmod() determines whether chmod can set all the mode bits. According to the docs, it's only limited on Windows, so I'll hardcode that. (It's also limited on WASI, but in 3.10 tests we don't care.)

I can't push fixes to your repo so I opened #104327.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mcepl

mcepl commented May 9, 2023

Copy link
Copy Markdown
Contributor Author

I can't push fixes to your repo so I opened #104327.

Sorry about that, I don’t know how to set it up with the existing PR.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@encukou @mcepl
Skip chmod checking on Windows
7ab6233
@encukou encukou added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 9, 2023
@mcepl

mcepl commented May 9, 2023

Copy link
Copy Markdown
Contributor Author

Couldn’t you just make PR to https://github.com/openSUSE-Python/cpython/tree/PEP706-for-py310 ?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot

bedevere-bot commented May 9, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @encukou for commit 7ab6233 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 9, 2023
@encukou

encukou commented May 9, 2023

Copy link
Copy Markdown
Member

I don't think I could run CPython buildbots on another repo.
But since you've updated this PR quickly, I'll run them here.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@encukou

encukou commented May 10, 2023

Copy link
Copy Markdown
Member

The red checks are unrelated: Python 3.10 doesn't build on Wasm, and RtD's OpenSSL is too old for urllib3.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@encukou
encukou merged commit 425065b into python:3.10 May 10, 2023
@bedevere-bot bedevere-bot removed the awaiting review label May 10, 2023
@encukou

encukou commented May 10, 2023

Copy link
Copy Markdown
Member

Thanks for the backport!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mcepl
mcepl deleted the PEP706-for-py310 branch May 10, 2023 12:27
@mcepl

mcepl commented May 10, 2023

Copy link
Copy Markdown
Contributor Author

So, now 3.9! :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@coderabbitai coderabbitai Bot mentioned this pull request Aug 18, 2026
feat(ci): prove published release golden path Rul1an/assay#2513
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou left review comments
@ethanfurman ethanfurman Awaiting requested review from ethanfurman ethanfurman is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@mcepl @encukou @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.