GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||
GeezerVison is showing github.com — gh-97556: Raise null bytes syntax error upon null in multiline string by lysnikolaou · Pull Request #104136 · python/cpython Conversation
|
That's a good idea. Where would you add these One of the items I have in my to-do list is to add comments and assert in various places in the tokenizer to make the logic a bit easier to follow. Would it be okay to merge this as-is and then do that in a separate PR? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Absolutely, let's merge this as is 🚀 Great job as always man! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@lysnikolaou: Do you consider backporting your change to Python 3.11? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
See discussion linked in the associated issue, there was a decision made not to backport the initial change that worked for single quoted strings, to avoid breaking compatibility in a patch version release. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
See #96670 (comment) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
FYI I removed the label until it's more clear what should be backported. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
GH-104195 includes a backport of this commit to 3.11. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.