GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] gh-96670: Raise SyntaxError when parsing NULL bytes (GH-97594) by lysnikolaou · Pull Request #104195 · python/cpython

Conversation

@lysnikolaou

@lysnikolaou lysnikolaou commented May 5, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

(cherry picked from commit aab01e3)

  • Issue: mishandling of c-strings in parser #96670
  • Also: Null characters in strings cause a C SystemError #97556

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@lysnikolaou @pablogsal
[3.11] pythongh-96670: Raise SyntaxError when parsing NULL bytes (pyt…
e6d28ba 
…honGH-97594).

(cherry picked from commit aab01e3)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
@lysnikolaou
lysnikolaou requested review from iritkatriel and pablogsal as code owners May 5, 2023 09:17
This was referenced May 5, 2023
mishandling of c-strings in parser #96670
Closed
gh-96670: Raise SyntaxError when parsing NULL bytes #97594
Merged
@bedevere-bot bedevere-bot added the awaiting core review label May 5, 2023
@lysnikolaou
[3.11] Raise null bytes syntax error upon null in multiline string
c0b64eb
@lysnikolaou

lysnikolaou commented May 5, 2023

Copy link
Copy Markdown
Member Author

@pablogsal I'm not sure what to do with the NEWS file from your original PR. Leave it as-is and include it here, skip it or write a new one with something like "Backporting to 3.11"?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lysnikolaou lysnikolaou mentioned this pull request May 5, 2023
gh-97556: Raise null bytes syntax error upon null in multiline string #104136
Merged
@pablogsal

pablogsal commented May 5, 2023

Copy link
Copy Markdown
Member

@pablogsal I'm not sure what to do with the NEWS file from your original PR. Leave it as-is and include it here, skip it or write a new one with something like "Backporting to 3.11"?

I would leave it the same and maybe add at the end (backported from ...)
lysnikolaou reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lysnikolaou

lysnikolaou commented May 5, 2023

Copy link
Copy Markdown
Member Author

I would leave it the same and maybe add at the end (backported from ...)

Done! Thanks for the help!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lysnikolaou
Add news blurb
de5f0b3
@lysnikolaou
lysnikolaou force-pushed the backport-aab01e3-3.11 branch from f0c0f22 to de5f0b3 Compare May 5, 2023 18:23
@pablogsal
pablogsal merged commit a09d390 into python:3.11 May 7, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label May 7, 2023
@vEpiphyte vEpiphyte mentioned this pull request Jun 7, 2023
Handle SyntaxError which can be raised by cpython in 3.11.4+ (SYN-5563) vertexproject/synapse#3172
Merged
The-Compiler added a commit to qutebrowser/qutebrowser that referenced this pull request Jun 9, 2023
@The-Compiler
test: Adjust test_nul_bytes version check
8b05838 
Python 3.11.4 also got the fix backported which turns this into a SyntaxError:
python/cpython#104195
This was referenced Nov 4, 2023
Changes in Python 3.12 break tests PythonCharmers/python-future#618
Closed
test_check_nullbytes regressed on 3.11.4 PyCQA/pycodestyle#1151
Closed
@devdanzin devdanzin mentioned this pull request Jul 30, 2024
Incorrect information about exception raised if source contains null bytes for ast.parse() and compile() #122461
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner
@iritkatriel iritkatriel Awaiting requested review from iritkatriel iritkatriel is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@lysnikolaou @pablogsal @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.