Description

erlend-aasland

opened on May 3, 2023

Issue body actions

There's a bit of unused code in clinic.py. For example, the code that manipulated second_pass_replacements was removed in 2015 (commit 0759f84, gh-67688 (bpo-23500)), but the variable and a branch depending on it still persists.

Suggesting to remove all unused code in order to make clinic more readable and maintainable.

Linked PRs

• gh-104146: Remove unused 'second_pass_replacements' from clinic.py #104147
• gh-104146: Remove unused var 'parser_body_declarations' from clinic.py #104214
• gh-104146: Remove unused vars from Argument Clinic #104627
• gh-104146: Purge dead code from Argument Clinic #104680
• gh-104146: Remove unused attr 'parameter_indent' from clinic.DLParser #106358
• gh-104146: Remove dead code from Argument Clinic #107555
• gh-104146: Argument clinic: remove unused methods and variables #107608
• gh-104146: Argument clinic: Remove dead code flagged by mypy's truthy-bool check #107627
• gh-104146: Argument clinic: remove dead code highlighted by the vulture tool #107632
• gh-104146: Purge CConverter.parse_by_reference from Argument Clinic #119162

Activity

1. erlend-aasland

   added

   topic-argument-clinic

   on May 3, 2023
2. erlend-aasland

   self-assigned this

   on May 3, 2023
3. erlend-aasland

   added 2 commits that reference this issue on May 3, 2023

   pythongh-104146: Remove unused 'second_pass_replacements' from clinic.py

   9768f7f

   pythongh-104146: Remove unused 'second_pass_replacements' from clinic.py

   396125f
4. erlend-aasland

   linked a pull request that will close this issuegh-104146: Remove unused 'second_pass_replacements' from clinic.py #104147on May 3, 2023
5. erlend-aasland

   closed this as completedin #104147on May 4, 2023
6. erlend-aasland

   added a commit that references this issue on May 4, 2023

   gh-104146: Remove unused 'second_pass_replacements' from clinic.py (#…

   9885677
7. erlend-aasland

   reopened this on May 5, 2023
8. erlend-aasland

   added a commit that references this issue on May 5, 2023

   pythongh-104146: Remove unused var 'parser_body_declarations' from cl…

   dcf8cca
9. erlend-aasland

   linked a pull request that will close this issuegh-104146: Remove unused var 'parser_body_declarations' from clinic.py #104214on May 5, 2023
10. erlend-aasland

    closed this as completedin #104214on May 5, 2023
11. erlend-aasland

    added a commit that references this issue on May 5, 2023

    gh-104146: Remove unused var 'parser_body_declarations' from clinic.py (

    66558d2
12. carljm

    added a commit that references this issue on May 5, 2023

    Merge branch 'main' into inlinecomp2

    baacf5f
13. jbower-fb

    added a commit that references this issue on May 8, 2023

    pythongh-104146: Remove unused var 'parser_body_declarations' from cl…

    c205faa
14. erlend-aasland

    reopened this on May 18, 2023
15. 18 remaining items
16. erlend-aasland

    added a commit that references this issue on Jul 3, 2023

    gh-104146: Remove unused attr 'parameter_indent' from clinic.DLParser (…

    60e41a0
17. carljm

    added a commit that references this issue on Jul 3, 2023

    Merge branch 'main' into modulelocals

    ac11740
18. erlend-aasland

    reopened this on Aug 2, 2023
19. erlend-aasland

    added a commit that references this issue on Aug 2, 2023

    pythongh-104146: Remove dead code from Argument Clinic

    8c3e9fa
20. erlend-aasland

    linked a pull request that will close this issuegh-104146: Remove dead code from Argument Clinic #107555on Aug 2, 2023
21. erlend-aasland

    closed this as completedin #107555on Aug 2, 2023
22. erlend-aasland

    added a commit that references this issue on Aug 2, 2023

    gh-104146: Remove dead code from Argument Clinic (#107555)

    439466a
23. AlexWaygood

    added 3 commits that reference this issue on Aug 4, 2023

    gh-104146: Argument clinic: remove unused methods and variables (#107608

    ee78d01

    pythongh-104146: Argument clinic: Remove dead code flagged by mypy's …

    0ad381c

    pythongh-104146: Argument clinic: Remove dead code flagged by mypy's …

    5fc7e12
24. erlend-aasland

    reopened this on Aug 4, 2023
25. AlexWaygood

    added 2 commits that reference this issue on Aug 4, 2023

    gh-104146: Argument clinic: Remove dead code flagged by mypy's `truth…

    7eba274

    gh-104146: Argument clinic: remove dead code highlighted by the `vult…

    407d7fd
26. erlend-aasland

    closed this as completedon Aug 30, 2023
27. erlend-aasland

    added a commit that references this issue on May 18, 2024

    pythongh-104146: Purge CConverter.parse_by_reference from Argument Cl…

    4218357

Issue actions