GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-97696: Remove redundant #include by jbower-fb · Pull Request #104216 · python/cpython

Conversation

@jbower-fb

@jbower-fb jbower-fb commented May 5, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

As per discussion on #102853.

  • Issue: Add eager task creation API to asyncio #97696

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
itamaro reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@jbower-fb
Remove redundant #include
d216c52
@jbower-fb
jbower-fb requested review from 1st1, asvetlov, gvanrossum, kumaraditya303 and willingc as code owners May 5, 2023 21:27
@bedevere-bot bedevere-bot mentioned this pull request May 5, 2023
Add eager task creation API to asyncio #97696
Closed
@bedevere-bot bedevere-bot added the awaiting review label May 5, 2023
@hauntsaninja hauntsaninja added the skip news label May 5, 2023
@hauntsaninja hauntsaninja changed the title gh-97696 Remove redundant #include gh-97696: Remove redundant #include May 5, 2023
itamaro
itamaro approved these changes May 5, 2023
View reviewed changes

@itamaro itamaro left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for cleaning this up @jbower-fb!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels May 5, 2023
@gvanrossum
gvanrossum merged commit 8b7f37d into python:main May 5, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label May 5, 2023
@jbower-fb
jbower-fb deleted the deadinclude branch May 6, 2023 01:02
jbower-fb added a commit to jbower-fb/cpython that referenced this pull request May 8, 2023
@jbower-fb
pythongh-97696: Remove redundant #include (python#104216)
8df75f2 
Remove "#include cpython/context.h"` from `_asynciomodule.c`.

It's already included in `Python.h`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itamaro itamaro itamaro approved these changes
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@gvanrossum gvanrossum Awaiting requested review from gvanrossum
@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner
@willingc willingc Awaiting requested review from willingc willingc is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@jbower-fb @itamaro @gvanrossum @hauntsaninja @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.