GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-104254: Document the optional keyword-only "context" argument to Task constructor by itamaro · Pull Request #104251 · python/cpython

Conversation

@itamaro

@itamaro itamaro commented May 6, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

📚 Documentation preview 📚: https://cpython-previews--104251.org.readthedocs.build/

  • Issue: Task object in asyncio docs is missing the "context" argument #104254

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@itamaro
Document the optional keyword-only "context" argument to Task constru…
f94d22f 
…ctor
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news labels May 6, 2023
@itamaro itamaro changed the title Document the optional keyword-only "context" argument to Task constructor gh-104254: Document the optional keyword-only "context" argument to Task constructor May 7, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 7, 2023
Task object in asyncio docs is missing the "context" argument #104254
Closed
@itamaro
itamaro marked this pull request as ready for review May 7, 2023 00:17
@itamaro
itamaro requested review from 1st1, asvetlov, gvanrossum, kumaraditya303 and willingc as code owners May 7, 2023 00:17
This was referenced May 7, 2023
gh-104144: Skip scheduling a done callback if a TaskGroup task completes eagerly #104140
Merged
Add eager task creation API to asyncio #97696
Closed
@gvanrossum
gvanrossum merged commit 4ee2068 into python:main May 7, 2023
@itamaro

itamaro commented May 7, 2023

Copy link
Copy Markdown
Contributor Author

thanks for merging! should this be backported to 3.11 too?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gvanrossum gvanrossum added the needs backport to 3.11 only security fixes label May 7, 2023
@miss-islington

miss-islington commented May 7, 2023

Copy link
Copy Markdown
Contributor

Thanks @itamaro for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented May 7, 2023

Copy link
Copy Markdown

GH-104258 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label May 7, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 7, 2023
@itamaro @miss-islington
pythongh-104254: Document the optional keyword-only "context" argumen…
41a5b14 
…t to Task constructor (pythonGH-104251)

(This was added in 3.11. It was already documented for `create_task()`, but not for `Task()`.)
(cherry picked from commit 4ee2068)

Co-authored-by: Itamar Ostricher <[email protected]>
kumaraditya303 pushed a commit that referenced this pull request May 7, 2023
@miss-islington @itamaro
[3.11] gh-104254: Document the optional keyword-only "context" argume…
efcd4bc 
…nt to Task constructor (GH-104251) (#104258)

gh-104254: Document the optional keyword-only "context" argument to Task constructor (GH-104251)

(This was added in 3.11. It was already documented for `create_task()`, but not for `Task()`.)
(cherry picked from commit 4ee2068)

Co-authored-by: Itamar Ostricher <[email protected]>
@itamaro
itamaro deleted the asyncio-docs-context branch May 7, 2023 04:51
jbower-fb pushed a commit to jbower-fb/cpython that referenced this pull request May 8, 2023
@itamaro @jbower-fb
pythongh-104254: Document the optional keyword-only "context" argumen…
fe13226 
…t to Task constructor (python#104251)

(This was added in 3.11. It was already documented for `create_task()`, but not for `Task()`.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@gvanrossum gvanrossum Awaiting requested review from gvanrossum
@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner
@willingc willingc Awaiting requested review from willingc willingc is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@itamaro @miss-islington @bedevere-bot @gvanrossum
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.