GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-97696: Use PyObject_CallMethodNoArgs and inline is_loop_running check by itamaro · Pull Request #104255 · python/cpython

Conversation

@itamaro

@itamaro itamaro commented May 7, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

based on feedback from #102853 (review)

  • Issue: Add eager task creation API to asyncio #97696

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@itamaro
pythongh-97696: Use PyObject_CallMethodNoArgs and inline is_loop_runn…
20048db 
…ing check

based on feedback from python#102853 (review)
@itamaro
itamaro requested review from 1st1, asvetlov, gvanrossum, kumaraditya303 and willingc as code owners May 7, 2023 00:36
@bedevere-bot bedevere-bot mentioned this pull request May 7, 2023
Add eager task creation API to asyncio #97696
Closed
@bedevere-bot bedevere-bot added the awaiting review label May 7, 2023
gvanrossum
gvanrossum approved these changes May 7, 2023
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but this was @kumaraditya303's idea so he can review and merge it.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
itamaro reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels May 7, 2023
@gvanrossum gvanrossum added the skip news label May 7, 2023
@itamaro

itamaro commented May 7, 2023

Copy link
Copy Markdown
Contributor Author

LGTM, but this was @kumaraditya303's idea so he can review and merge it.

thanks! can you trigger refleak buildbots in the meantime so @kumaraditya303 can merge with confidence when he gets to it? :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra JelleZijlstra added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label May 7, 2023
@bedevere-bot

bedevere-bot commented May 7, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @JelleZijlstra for commit 20048db 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label May 7, 2023
kumaraditya303
kumaraditya303 approved these changes May 7, 2023
View reviewed changes
@kumaraditya303
kumaraditya303 merged commit c53547c into python:main May 7, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label May 7, 2023
@itamaro
itamaro deleted the inline-is-loop-running branch May 7, 2023 04:50
jbower-fb pushed a commit to jbower-fb/cpython that referenced this pull request May 8, 2023
@itamaro @jbower-fb
pythongh-97696: Use PyObject_CallMethodNoArgs and inline is_loop_ru…
44b081d 
…nning check in `_asyncio` (python#104255)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes
@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@willingc willingc Awaiting requested review from willingc willingc is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@itamaro @bedevere-bot @gvanrossum @kumaraditya303 @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.