GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-104469 Convert _testcapi/exceptions to use AC by corona10 · Pull Request #104502 · python/cpython

Conversation

@corona10

@corona10 corona10 commented May 15, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Improve the readability and maintainability of test_capi using the AC #104469

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@corona10
pythongh-104469 Convert _testcapi/exceptions to use AC
4912e14
@bedevere-bot bedevere-bot added the awaiting core review label May 15, 2023
@corona10
corona10 requested a review from erlend-aasland May 15, 2023 09:14
@bedevere-bot bedevere-bot mentioned this pull request May 15, 2023
Improve the readability and maintainability of test_capi using the AC #104469
Closed
@corona10 corona10 added the skip news label May 15, 2023
@corona10
Fix signature
1b085dc
@corona10 corona10 mentioned this pull request May 15, 2023
gh-104469: Convert _testcapi/watchers.c to use AC #104503
Merged
@corona10
Follow the guideline
03de258
@corona10

corona10 commented May 17, 2023

Copy link
Copy Markdown
Member Author

@erlend-aasland @sobolevn Would you like to take a look?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10
Unified params
b81f472
sobolevn
sobolevn reviewed May 17, 2023
View reviewed changes
Comment thread Modules/_testcapi/exceptions.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_testcapi/exceptions.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@corona10
Address code review
19918cf
@corona10
corona10 requested a review from sobolevn May 18, 2023 01:01
@corona10

corona10 commented May 18, 2023

Copy link
Copy Markdown
Member Author

@sobolevn Thanks! Updated!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland
erlend-aasland reviewed May 18, 2023
View reviewed changes
Comment thread Modules/_testcapi/exceptions.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_testcapi/exceptions.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@corona10
Address code review
74af1a5
@corona10
corona10 requested a review from erlend-aasland May 19, 2023 11:56
@corona10

corona10 commented May 19, 2023

Copy link
Copy Markdown
Member Author

@erlend-aasland Thanks! PTAL one more time!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland
erlend-aasland approved these changes May 21, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels May 21, 2023
@corona10
corona10 merged commit 2e91c7e into python:main May 21, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label May 21, 2023
@corona10
corona10 deleted the gh-104469-exceptions branch May 21, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes
@sobolevn sobolevn Awaiting requested review from sobolevn

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@corona10 @sobolevn @erlend-aasland @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.