GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-104469: Convert _testcapi/watchers.c to use AC by sobolevn · Pull Request #104503 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented May 15, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Skipping news, because there are not use-facing changes.
CC @corona10 @erlend-aasland

  • Issue: Improve the readability and maintainability of test_capi using the AC #104469

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn
pythongh-104469: Convert _testcapi/watchers.c to use AC
559d74f
@bedevere-bot bedevere-bot added the awaiting review label May 15, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 15, 2023
Improve the readability and maintainability of test_capi using the AC #104469
Closed
@sobolevn sobolevn added the skip news label May 15, 2023
@sobolevn

sobolevn commented May 15, 2023

Copy link
Copy Markdown
Member Author

As far as I know, Test Hypothesis failure is not related
Eclips4 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
erlend-aasland self-requested a review May 15, 2023 11:40
@sobolevn
Address review
ec2f0b0
erlend-aasland
erlend-aasland reviewed May 15, 2023
View reviewed changes
Comment thread Modules/_testcapi/watchers.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented May 15, 2023

Copy link
Copy Markdown
Contributor

Also, remember to make clinic before pushing.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented May 15, 2023

Copy link
Copy Markdown
Contributor

BTW, the rest of the tests should be cancelled if "Check if generated files are up to date" fails. CC. GitHub wizard @hugovk.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk

hugovk commented May 15, 2023 •
edited by AlexWaygood
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

"Check for source changes" is a gating step, but "Check if generated files are up to date" isn't:

image

https://github.com/python/cpython/actions/runs/4980218331?pr=104503

This is how the other steps depend on "Check four source changes" in https://github.com/python/cpython/blob/b378d991f8cd41c33416e590cb83472cce1d6b98/.github/workflows/build.yml:

    needs: check_source
    if: needs.check_source.outputs.run_tests == 'true'
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn
Fix CI
490e787
corona10
corona10 reviewed May 15, 2023
View reviewed changes
Comment thread Modules/_testcapi/watchers.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
corona10
corona10 reviewed May 15, 2023
View reviewed changes
Comment thread Modules/_testcapi/watchers.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
corona10
corona10 reviewed May 15, 2023
View reviewed changes
Comment thread Modules/_testcapi/watchers.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland
erlend-aasland approved these changes May 15, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels May 15, 2023
@erlend-aasland
erlend-aasland merged commit 456d566 into python:main May 15, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label May 15, 2023
carljm added a commit to carljm/cpython that referenced this pull request May 16, 2023
@carljm
Merge branch 'main' into supermon
a6dd626 
* main:
  pythonGH-104510: Fix refleaks in `_io` base types (python#104516)
  pythongh-104539: Fix indentation error in logging.config.rst (python#104545)
  pythongh-104050: Don't star-import 'types' in Argument Clinic (python#104543)
  pythongh-104050: Add basic typing to CConverter in clinic.py (python#104538)
  pythongh-64595: Fix write file logic in Argument Clinic (python#104507)
  pythongh-104523: Inline minimal PGO rules (python#104524)
  pythongh-103861: Fix Zip64 extensions not being properly applied in some cases (python#103863)
  pythongh-69152: add method get_proxy_response_headers to HTTPConnection class (python#104248)
  pythongh-103763: Implement PEP 695 (python#103764)
  pythongh-104461: Run tkinter test_configure_screen on X11 only (pythonGH-104462)
  pythongh-104469: Convert _testcapi/watchers.c to use Argument Clinic (python#104503)
  pythongh-104482: Fix error handling bugs in ast.c (python#104483)
  pythongh-104341: Adjust tstate_must_exit() to Respect Interpreter Finalization (pythongh-104437)
  pythonGH-102613: Fix recursion error from `pathlib.Path.glob()` (pythonGH-104373)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 corona10 left review comments
@erlend-aasland erlend-aasland erlend-aasland approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@sobolevn @erlend-aasland @hugovk @corona10 @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.