GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-101520: Move tracemalloc functionality into core, leaving interface in Modules. by markshannon · Pull Request #104508 · python/cpython

Conversation

@markshannon

@markshannon markshannon commented May 15, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This is a dumb refactoring.
All the new "API" functions are internal. They are marked PyAPI_FUNC for linkage.

  • Issue: Isolate the tracemalloc Module Between Interpreters #101520

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
markshannon added 4 commits May 11, 2023 21:01
@markshannon
Move tracemalloc functionality into core, leaving interface in Modules.
69c770f
@markshannon
Move clinic header back to correct file.
e2728be
@markshannon
Add news
eaf8717
@markshannon
Fix some typos.
efb95d0
@markshannon
markshannon requested a review from a team as a code owner May 15, 2023 13:28
@bedevere-bot bedevere-bot added the awaiting core review label May 15, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 15, 2023
Isolate the tracemalloc Module Between Interpreters #101520
Closed
Eclips4
Eclips4 reviewed May 15, 2023
View reviewed changes

@Eclips4 Eclips4 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some typos

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread Include/tracemalloc.h Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Include/tracemalloc.h Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Include/tracemalloc.h Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Include/tracemalloc.h Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Include/tracemalloc.h Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Include/tracemalloc.h Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Include/tracemalloc.h Resolved

Uh oh!

There was an error while loading. Please reload this page.

@markshannon

markshannon commented May 15, 2023

Copy link
Copy Markdown
Member Author

@Eclips4 Thanks for spotting those.

Eclips4 reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

JelleZijlstra
JelleZijlstra reviewed May 15, 2023
View reviewed changes
Comment thread Python/pylifecycle.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

markshannon and others added 2 commits May 15, 2023 18:04
@markshannon @JelleZijlstra
Update Python/pylifecycle.c
9be8435
Co-authored-by: Jelle Zijlstra <[email protected]>
@markshannon
Rename _PyTraceResetPeak to _PyTraceMalloc_ResetPeak
0dd7ba2
@brandtbucher
brandtbucher self-requested a review May 16, 2023 19:33
brandtbucher
brandtbucher approved these changes May 17, 2023
View reviewed changes

@brandtbucher brandtbucher left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (I didn't dig too closely into the moved code, but I'm trusting you that it's indeed a "dumb" refactoring).

Just one question on naming:

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread Include/tracemalloc.h Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Python/tracemalloc.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels May 17, 2023
@markshannon
markshannon merged commit f7df173 into python:main May 17, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label May 17, 2023
carljm added a commit to carljm/cpython that referenced this pull request May 17, 2023
@carljm
Merge branch 'main' into 709funconly
b1bb3a7
* main: (26 commits)
  pythonGH-101520: Move tracemalloc functionality into core, leaving interface in Modules. (python#104508)
  typing: Add more tests for TypeVar (python#104571)
  pythongh-104572: Improve error messages for invalid constructs in PEP 695 contexts (python#104573)
  typing: Use PEP 695 syntax in typing.py (python#104553)
  pythongh-102153: Start stripping C0 control and space chars in `urlsplit` (python#102508)
  pythongh-104469: Update README.txt for _testcapi (pythongh-104529)
  pythonGH-103092: isolate `_elementtree` (python#104561)
  pythongh-104050: Add typing to Argument Clinic converters (python#104547)
  pythonGH-103906: Remove immortal refcounting in the interpreter (pythonGH-103909)
  pythongh-87474: Fix file descriptor leaks in subprocess.Popen (python#96351)
  pythonGH-103092: isolate `pyexpat`  (python#104506)
  pythongh-75367: Fix data descriptor detection in inspect.getattr_static (python#104517)
  pythongh-104050: Add more annotations to `Tools/clinic.py` (python#104544)
  pythongh-104555: Fix isinstance() and issubclass() for runtime-checkable protocols that use PEP 695 (python#104556)
  pythongh-103865: add monitoring support to LOAD_SUPER_ATTR (python#103866)
  CODEOWNERS: Assign new PEP 695 files to myself (python#104551)
  pythonGH-104510: Fix refleaks in `_io` base types (python#104516)
  pythongh-104539: Fix indentation error in logging.config.rst (python#104545)
  pythongh-104050: Don't star-import 'types' in Argument Clinic (python#104543)
  pythongh-104050: Add basic typing to CConverter in clinic.py (python#104538)
  ...
JelleZijlstra pushed a commit to JelleZijlstra/cpython that referenced this pull request May 18, 2023
@markshannon @JelleZijlstra
pythonGH-101520: Move tracemalloc functionality into core, leaving in…
4fea66d
…terface in Modules. (python#104508)
@markshannon
markshannon deleted the move-tracemalloc-to-core branch September 26, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra left review comments
@Eclips4 Eclips4 Eclips4 left review comments
@brandtbucher brandtbucher brandtbucher approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@markshannon @JelleZijlstra @brandtbucher @Eclips4 @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.