GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.7] gh-102950: Implement PEP 706 – Filter for tarfile.extractall (GH-102953) by encukou · Pull Request #104583 · python/cpython

Conversation

@encukou

@encukou encukou commented May 17, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

See Backporting & Forward Compatibility in PEP 706.

  • Backport b52ad18
  • Backport c8c3956
  • Remove the DeprecationWarning
  • Remove new __all__ entries
  • Adjust docs
  • Backport a warning to shutil.unpack_archive docs

Nearly the same as the 3.8 backport, but it also backports the test.support.check_no_warnings function from 3.8+, since it's used in new tests.

  • Issue: Implement PEP 706 – Filter for tarfile.extractall #102950

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
encukou added 9 commits May 17, 2023 15:39
@encukou
Implement PEP 706 – Filter for tarfile.extractall
f089c53
@encukou
Downgrade to Python 3.6
9106981
@encukou
Remove the DeprecationWarning
3ab896b
@encukou
Backport test.support.check_no_warnings
300a1a8
@encukou
Remove new __all__ entries
7ea8050
@encukou
pythongh-102950: Adjust tarfile filter tests for systems that don't s…
921e5f1
…et the sticky bit (pythonGH-103831)

Also remove expilcit `type=tarfile.DIRTYPE`, the slash at the end is
enough.

Backport of c8c3956
@encukou
Skip chmod checking on Windows
fc9913d
@encukou
Adjust the docs for 3.7.17
a11a198
@encukou
Backport warning to shutil.unpack_archive docs
8332ea3
@bedevere-bot bedevere-bot added the awaiting core review label May 17, 2023
This was referenced May 17, 2023
Implement PEP 706 – Filter for tarfile.extractall #102950
Closed
gh-102950: Implement PEP 706 – Filter for tarfile.extractall #102953
Merged
@encukou
encukou marked this pull request as draft May 17, 2023 14:31
@bedevere-bot bedevere-bot removed the awaiting core review label May 17, 2023
@encukou

encukou commented May 18, 2023

Copy link
Copy Markdown
Member Author

Python 3.7, Windows and symlinks, oh my!
I'll investigate & fix next week.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

encukou and others added 4 commits May 23, 2023 15:23
@encukou
Skip test when an obscure Windows pathlib error appears
b626549
@encukou
Feed a string to os.readlink()
7ae4a88
@encukou
Fix syntax error
64d1a92
I pushed the wrong commit O.o
@ned-deily
Merge branch '3.7' into tarfile-3.7
773e47e
@encukou

encukou commented May 29, 2023

Copy link
Copy Markdown
Member Author

@ned-deily this was quite a rabbit hole, and I'm as far as I can go. Unfortunately, not far enough. See Discourse for details: https://discuss.python.org/t/23903/11

I'll run buildbots to check if this is fine for non-Windows platforms, but I don't think CPython 3.7 can ship it :(

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@encukou encukou added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 29, 2023
@bedevere-bot

bedevere-bot commented May 29, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @encukou for commit 773e47e 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 29, 2023
@ned-deily

ned-deily commented May 30, 2023

Copy link
Copy Markdown
Member

[...] but I don't think CPython 3.7 can ship it :(

Thank you, Petr, for all your work on this across all the active branches! Given your analysis of the current 3.7 patch's shortcoming and give that 3.7 is scheduled to reach end-of-life in just a few weeks, I agree with your conclusion that it would be too risky and disruptive to officially accept this change for 3.7. As you note, third-party distributors who plan to provide support for 3.7 beyond its official end-of-life date are free to use and adapt the patch for their customers and they will have the opportunity to provide updates to it as necessary. Considering that the shortcomings that this change address have existed and been documented for many years and considering that all subsequent versions of Python (i.e. 3.8 on) will have this fix available, I do not think there is a need to consider either rushing a fix into 3.7 before its end-of-life or extending 3.7's life.

encukou reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ned-deily ned-deily closed this May 30, 2023
@encukou

encukou commented May 30, 2023

Copy link
Copy Markdown
Member Author

All buildbot failures look unrelated -- cryptography/network, USAN/ASAN, unsupported platforms/missing tools (MSVC toolset version, Tk, Wasm, Windows ARM), timeouts, a readline fail.

They shouldn't prevent building Python 3.7 from source.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@coderabbitai coderabbitai Bot mentioned this pull request Jul 8, 2026
DEV-1649: persist + reuse the agent's edited slayer models per task MotleyAI/bird-agents#84
Merged
@coderabbitai coderabbitai Bot mentioned this pull request Aug 12, 2026
DEV-1778: stamp consumed edited-models store provenance onto runs MotleyAI/bird-agents#94
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@encukou @bedevere-bot @ned-deily
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.