GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-104050: Add type hints to Argument Clinic converter keywords by erlend-aasland · Pull Request #104588 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented May 17, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Introduce TypeSet, and use it to annotate the 'accept' keyword of
various C converters.

  • Issue: Add type annotations to clinic.py #104050

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@erlend-aasland
pythongh-104050: Add type hints to Argument Clinic converter keywords
9dd831e
Introduce TypeSet, and use it to annotate the 'accept' keyword of
various C converters.
@erlend-aasland erlend-aasland added the skip news label May 17, 2023
@erlend-aasland
erlend-aasland requested a review from AlexWaygood May 17, 2023 20:21
@bedevere-bot bedevere-bot added the awaiting core review label May 17, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 17, 2023
Add type annotations to clinic.py #104050
Closed
@erlend-aasland
Some more returns
ec11d79
AlexWaygood
AlexWaygood approved these changes May 17, 2023
View reviewed changes
Comment thread Tools/clinic/clinic.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels May 17, 2023
@erlend-aasland @AlexWaygood
Forgot one
ceeb3f1
Co-authored-by: Alex Waygood <[email protected]>
@erlend-aasland
erlend-aasland enabled auto-merge (squash) May 17, 2023 20:36
@erlend-aasland
erlend-aasland merged commit 2f369ca into python:main May 17, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label May 17, 2023
JelleZijlstra pushed a commit to JelleZijlstra/cpython that referenced this pull request May 18, 2023
@erlend-aasland @JelleZijlstra
pythongh-104050: Add type hints to Argument Clinic converter keywords (…
2bfdbe8
…python#104588)

Introduce TypeSet, and use it to annotate the 'accept' keyword of
various C converters. Also add some missing return annotations for
converter init functions.
@erlend-aasland
erlend-aasland deleted the typed-clinic/accept branch May 21, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@erlend-aasland @AlexWaygood @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.