GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-104499: IDLE - fix completions for tk aqua 8.7 by terryjreedy · Pull Request #104591 · python/cpython

Conversation

@terryjreedy

@terryjreedy terryjreedy commented May 17, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: IDLE: completions toplevel blank on Tk Aqua 8.7 #104499

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@terryjreedy
pythongh-104499: IDLE - fix completions for tk aqua 8.7
1f57426
@terryjreedy terryjreedy added the needs backport to 3.11 only security fixes label May 17, 2023
@terryjreedy terryjreedy self-assigned this May 17, 2023
@bedevere-bot bedevere-bot added the awaiting core review label May 17, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 17, 2023
IDLE: completions toplevel blank on Tk Aqua 8.7 #104499
Closed
chrstphrchvz
chrstphrchvz reviewed May 17, 2023
View reviewed changes
Comment thread Lib/idlelib/autocomplete_w.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@chrstphrchvz

chrstphrchvz commented May 17, 2023

Copy link
Copy Markdown
Contributor

I have verified that this change avoids the issue for current Tk Aqua 8.7 on macOS 12.6.5 Monterey (Intel).

Before:
Screen Shot 2023-05-17 at 5 54 57 PM
After:
Screen Shot 2023-05-17 at 5 52 15 PM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@terryjreedy
terryjreedy merged commit 678bf57 into python:main May 18, 2023
@miss-islington

miss-islington commented May 18, 2023

Copy link
Copy Markdown
Contributor

Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label May 18, 2023
@bedevere-bot

bedevere-bot commented May 18, 2023

Copy link
Copy Markdown

GH-104596 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label May 18, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 18, 2023
@terryjreedy @miss-islington
pythongh-104499: IDLE - fix completions for tk aqua 8.7 (pythonGH-104591
ff8ef9d 
)

(cherry picked from commit 678bf57)

Co-authored-by: Terry Jan Reedy <[email protected]>
@terryjreedy
terryjreedy deleted the compdraw branch May 18, 2023 01:37
JelleZijlstra pushed a commit to JelleZijlstra/cpython that referenced this pull request May 18, 2023
@terryjreedy @JelleZijlstra
pythongh-104499: IDLE - fix completions for tk aqua 8.7 (python#104591)
a5a7344
terryjreedy added a commit that referenced this pull request May 18, 2023
@miss-islington @terryjreedy
[3.11] gh-104499: IDLE - fix completions for tk aqua 8.7 (GH-104591) (#…
e96fb39 
…104596)

gh-104499: IDLE - fix completions for tk aqua 8.7 (GH-104591)
(cherry picked from commit 678bf57)

Co-authored-by: Terry Jan Reedy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@chrstphrchvz chrstphrchvz chrstphrchvz left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@terryjreedy terryjreedy

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@terryjreedy @chrstphrchvz @miss-islington @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.