GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] gh-104629: Don't skip test_clinic if _testclinic is missing (GH-104630) by miss-islington · Pull Request #104632 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented May 18, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Just skip the tests that depend on the _testclinic extension module;
we can still run the Python tests.
(cherry picked from commit 86ee49f)

Co-authored-by: Erlend E. Aasland [email protected]

  • Issue: Clinic test are skipped on Windows #104629

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland @miss-islington
pythongh-104629: Don't skip test_clinic if _testclinic is missing (py…
e966306 
…thonGH-104630)

Just skip the tests that depend on the _testclinic extension module;
we can still run the Python tests.
(cherry picked from commit 86ee49f)

Co-authored-by: Erlend E. Aasland <[email protected]>
@bedevere-bot bedevere-bot added the awaiting review label May 18, 2023
This was referenced May 18, 2023
Clinic test are skipped on Windows #104629
Closed
gh-104629: Don't skip test_clinic if _testclinic is missing #104630
Merged
@bedevere-bot bedevere-bot added skip news tests Tests in the Lib/test dir labels May 18, 2023
@AlexWaygood
AlexWaygood enabled auto-merge (squash) May 18, 2023 23:00
erlend-aasland
erlend-aasland approved these changes May 18, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels May 18, 2023
@AlexWaygood
AlexWaygood merged commit 3d52f7e into python:3.11 May 18, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label May 18, 2023
@miss-islington
miss-islington deleted the backport-86ee49f-3.11 branch May 18, 2023 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @erlend-aasland @bedevere-bot @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.