Description

erlend-aasland

opened on May 18, 2023

Issue body actions

test_clinic is skipped on Windows. This is a regression introduced by gh-96178.

• The Modules/_testclinic.c helper extension module is not included in the Windows build
• test.support.import_helper.import_module("_testclinic") fails and skips the whole test, since _testclinic is not found

Linked PRs

• gh-104629: Don't skip test_clinic if _testclinic is missing #104630
• [3.11] gh-104629: Don't skip test_clinic if _testclinic is missing (GH-104630) #104632
• gh-104629: Build _testclinic extension module on Windows #104723
• [3.12] gh-104629: Build _testclinic extension module on Windows (GH-104723) #107393

Reacted by Alex Waygood and sunmy2019

Activity

1. erlend-aasland

   added

   type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

   OS-windows

   buildThe build process and cross-buildThe build process and cross-build

   on May 18, 2023
2. erlend-aasland

   added a commit that references this issue on May 18, 2023

   pythongh-104629: Don't skip test_clinic if _testclinic is missing

   f483652
3. erlend-aasland commented on May 18, 2023

   

   erlend-aasland

   on May 18, 2023

   ContributorAuthor

   More actions

   I'll leave the Windows specific part to someone with a Windows dev environment set up; I'm not comfortable doing the needed build changes in PCbuild/.

   cc. @python/windows-team
4. erlend-aasland

   added a commit that references this issue on May 18, 2023

   gh-104629: Don't skip test_clinic if _testclinic is missing (#104630)

   86ee49f
5. miss-islington

   added a commit that references this issue on May 18, 2023

   pythongh-104629: Don't skip test_clinic if _testclinic is missing (py…

   e966306
6. AlexWaygood

   added a commit that references this issue on May 18, 2023

   [3.11] gh-104629: Don't skip test_clinic if _testclinic is missing (G…

   3d52f7e
7. carljm

   added a commit that references this issue on May 18, 2023

   Merge branch 'main' into nestedcomps

   54095f0
8. erlend-aasland

   added a commit that references this issue on May 21, 2023

   pythongh-104629: Build _testclinic extension module on Windows

   b0f5a4e
9. miss-islington

   added a commit that references this issue on Jul 28, 2023

   pythongh-104629: Build _testclinic extension module on Windows (pytho…

   55a45d6
10. erlend-aasland

    added 2 commits that reference this issue on Jul 28, 2023

    gh-104629: Build _testclinic extension module on Windows (#104723)

    3a1d819

    [3.12] gh-104629: Build _testclinic extension module on Windows (GH-1…

    b4355de
11. hugovk commented on Nov 10, 2023

    

    hugovk

    on Nov 10, 2023

    Member

    More actions

    I'll leave the Windows specific part to someone with a Windows dev environment set up; I'm not comfortable doing the needed build changes in PCbuild/.

    Is everything done now? Can we close this issue? Thanks!
12. AlexWaygood commented on Nov 10, 2023

    

    AlexWaygood

    on Nov 10, 2023

    Member

    More actions

    As far as I can tell, all clinic tests are now executed when I run python -m test test_clinic -v locally on my Windows box 🥳

    Reacted by Hugo van Kemenade
13. AlexWaygood

    closed this as completedon Nov 10, 2023

Issue actions