GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-104698: Fix reference leak in mmapmodule.c by Eclips4 · Pull Request #104700 · python/cpython

Conversation

@Eclips4

@Eclips4 Eclips4 commented May 20, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Since macro CHECK_VALID need to redesigned to solve this error, I decided to write new macro CHECK_VALID_AND_RELEASE, which behave the same as CHECK_VALID, but also release a buffer.

  • Issue: test_mmap are leaked #104698

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Eclips4
pythongh-104698: Fix reference leak in mmapmodule.c
f973151
@bedevere-bot bedevere-bot added the awaiting review label May 20, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 20, 2023
test_mmap are leaked #104698
Closed
@Eclips4

Eclips4 commented May 20, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

сс @sunmy2019 @chgnrdv
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sunmy2019
sunmy2019 reviewed May 20, 2023
View reviewed changes
Comment thread Modules/mmapmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@sunmy2019
sunmy2019 requested a review from JelleZijlstra May 20, 2023 17:57
Eclips4 added 2 commits May 20, 2023 21:05
@Eclips4
Rename macro
42a4cb1
@Eclips4
Adjust slash position in macro definition
a4341c7
@sunmy2019 sunmy2019 added the skip news label May 20, 2023
@JelleZijlstra JelleZijlstra added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label May 20, 2023
@bedevere-bot

bedevere-bot commented May 20, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @JelleZijlstra for commit a4341c7 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label May 20, 2023
JelleZijlstra
JelleZijlstra reviewed May 20, 2023
View reviewed changes

@JelleZijlstra JelleZijlstra left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Two small suggestions.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Eclips4 reacted with heart emoji
All reactions
  • ❤️ 1 reaction
Comment thread Modules/mmapmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/mmapmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
JelleZijlstra added 2 commits May 20, 2023 16:48
@JelleZijlstra
Update Modules/mmapmodule.c
1162ef0
@JelleZijlstra
Update Modules/mmapmodule.c
80cd032
pablogsal
pablogsal approved these changes May 21, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels May 21, 2023
@pablogsal
pablogsal merged commit 99b6418 into python:main May 21, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label May 21, 2023
@pablogsal

pablogsal commented May 21, 2023

Copy link
Copy Markdown
Member

Mergin to fix the refleak buildbots and reduce the noise in main. Thanks for the PR @Eclips4 !
Eclips4 reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal pablogsal added the needs backport to 3.11 only security fixes label May 21, 2023
@miss-islington

miss-islington commented May 21, 2023

Copy link
Copy Markdown
Contributor

Thanks @Eclips4 for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented May 21, 2023

Copy link
Copy Markdown

GH-104710 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label May 21, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 21, 2023
@Eclips4 @JelleZijlstra @miss-islington
pythongh-104698: Fix reference leak in mmapmodule.c (pythonGH-104700)
914dbdc 
(cherry picked from commit 99b6418)

Co-authored-by: Kirill Podoprigora <[email protected]>
Co-authored-by: Jelle Zijlstra <[email protected]>
JelleZijlstra added a commit that referenced this pull request May 21, 2023
@miss-islington @Eclips4 @JelleZijlstra
[3.11] gh-104698: Fix reference leak in mmapmodule.c (GH-104700) (#10…
b2e0201 
…4710)

(cherry picked from commit 99b6418)

Co-authored-by: Kirill Podoprigora <[email protected]>
Co-authored-by: Jelle Zijlstra <[email protected]>
@Eclips4
Eclips4 deleted the issue-104698 branch May 21, 2023 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra left review comments
@sunmy2019 sunmy2019 sunmy2019 left review comments
@pablogsal pablogsal pablogsal approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@Eclips4 @bedevere-bot @pablogsal @miss-islington @JelleZijlstra @sunmy2019
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.