GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-101291: Avoid using macros with casts in low-level long API. by markshannon · Pull Request #104742 · python/cpython

Conversation

@markshannon

@markshannon markshannon commented May 22, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Stick to inline functions and plain assert to avoid losing constness.
Fixes C++ compiler warnings.
See #101685 (comment)

  • Issue: Restore (or beat) Python 2 performance for arithmetic operations on ints that fit into a single word #101291

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@markshannon
Avoid twisty maze of macros.
3f3a1f2
@bedevere-bot bedevere-bot added the awaiting core review label May 22, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 22, 2023
Restore (or beat) Python 2 performance for arithmetic operations on ints that fit into a single word #101291
Closed
@markshannon markshannon added the skip news label May 22, 2023
@markshannon

markshannon commented May 22, 2023

Copy link
Copy Markdown
Member Author

@rwgk can you confirm that this fixes the pybind11 compilation issue?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rwgk

rwgk commented May 22, 2023

Copy link
Copy Markdown

@rwgk can you confirm that this fixes the pybind11 compilation issue?

Yes, confirmed! Thanks for the quick fix!

Building all pybind11 unit tests works again.

For completeness: I'm currently unable to run the full suite of pybind11 unit tests b/o an unrelated problem (#103912 (comment)).
markshannon reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iritkatriel
iritkatriel approved these changes May 22, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels May 22, 2023
@iritkatriel
iritkatriel merged commit e295d86 into python:main May 22, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label May 22, 2023
@JelleZijlstra JelleZijlstra added the needs backport to 3.12 only security fixes label May 22, 2023
@miss-islington

miss-islington commented May 22, 2023

Copy link
Copy Markdown
Contributor

Thanks @markshannon for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 22, 2023
@markshannon @miss-islington
pythonGH-101291: Avoid using macros with casts in low-level long API. (…
fd90299 
…pythonGH-104742)

(cherry picked from commit e295d86)

Co-authored-by: Mark Shannon <[email protected]>
@bedevere-bot

bedevere-bot commented May 22, 2023

Copy link
Copy Markdown

GH-104759 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label May 22, 2023
@JelleZijlstra

JelleZijlstra commented May 22, 2023

Copy link
Copy Markdown
Member

(Backporting since this fixes compiler warnings from a recent change, so this counts as a bug fix.)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JelleZijlstra pushed a commit that referenced this pull request May 23, 2023
@miss-islington @markshannon
[3.12] GH-101291: Avoid using macros with casts in low-level long API. (
e43fbbd 
GH-104742) (#104759)

(cherry picked from commit e295d86)

Co-authored-by: Mark Shannon <[email protected]>
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
3.12 backport gh 105236 #105358
Closed
@markshannon
markshannon deleted the fix-long-asserts branch September 26, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@markshannon @rwgk @miss-islington @bedevere-bot @JelleZijlstra @iritkatriel
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.