GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-101282: Enclose BOLT_APPLY_FLAGS value in double quotes by corona10 · Pull Request #104752 · python/cpython

Conversation

corona10 commented May 22, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Issue: Enhance the BOLT build process #101282

Without this revert on macOS:

checking for --enable-bolt... no
checking BOLT_INSTRUMENT_FLAGS...
checking BOLT_APPLY_FLAGS... ./configure: line 8401: -reorder-blocks=ext-tsp: command not found

With this revert on macOS:

checking BOLT_INSTRUMENT_FLAGS...
checking BOLT_APPLY_FLAGS... -update-debug-sections -reorder-blocks=ext-tsp -reorder-functions=hfsort+ -split-functions -icf=1 -inline-all -split-eh -reorder-functions-use-hot-size -peepholes=none -jump-tables=aggressive -inline-ap -indirect-call-promotion=all -dyno-stats -use-gnu-stack -frame-opt=hot

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          pythongh-101282: Fix M4 style for BOLT configuration

e9597e5

corona10 requested a review from ned-deily

May 22, 2023 16:02

corona10 requested a review from erlend-aasland as a code owner

May 22, 2023 16:02

bedevere-bot added the awaiting core review label

May 22, 2023

bedevere-bot mentioned this pull request

May 22, 2023

Enhance the BOLT build process #101282

Closed

4 tasks done

corona10 added the skip news label

May 22, 2023

corona10 assigned erlend-aasland and Yhg1s

May 22, 2023

corona10 commented May 23, 2023

Copy link

Copy Markdown

Member Author

cc @indygreg Not decided yet which PR will be merged

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

corona10 added the needs backport to 3.12 only security fixes label

May 23, 2023

erlend-aasland commented May 23, 2023

Copy link

Copy Markdown

Contributor

Dong-hee: I'll take a look tonight (CET).

corona10 reacted with heart emoji

All reactions

❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

corona10 mentioned this pull request

May 23, 2023

gh-101282: Group and quote BOLT CLI flags #104821

Closed

erlend-aasland reviewed

May 24, 2023

View reviewed changes

Comment thread

configure.ac Resolved

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland requested changes

May 24, 2023

View reviewed changes

erlend-aasland left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/python/cpython/pull/104752/files#r1203531051

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-bot added awaiting changes and removed awaiting core review labels

May 24, 2023

bedevere-bot commented May 24, 2023

Copy link

Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland changed the title ~~gh-101282: Fix M4 style for BOLT configuration~~ gh-101282: Enclose BOLT_APPLY_FLAGS value in double quotes

May 24, 2023

erlend-aasland mentioned this pull request

May 24, 2023

gh-101282: Revert some M4 style for BOLT configuration #104751

Closed


          Address code review

92fe907

erlend-aasland approved these changes

May 24, 2023

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting changes labels

May 24, 2023

erlend-aasland commented May 24, 2023

Copy link

Copy Markdown

Contributor

Thanks!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

corona10 merged commit c437851 into python:main

May 24, 2023

miss-islington commented May 24, 2023

Copy link

Copy Markdown

Contributor

Thanks @corona10 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the awaiting merge label

May 24, 2023

miss-islington commented May 24, 2023

Copy link

Copy Markdown

Contributor

Sorry @corona10, I had trouble checking out the 3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker c43785192c97698a0217a680b30baae22106ed3e 3.12

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington assigned corona10 and unassigned Yhg1s

May 24, 2023

miss-islington unassigned erlend-aasland

May 24, 2023

corona10 added a commit to corona10/cpython that referenced this pull request

May 24, 2023


          [3.12] pythongh-101282: Enclose BOLT_APPLY_FLAGS value in double quot…

36f5894

…es (pythongh-104752)

(cherry picked from commit c437851)

Co-authored-by: Dong-hee Na <[email protected]>

bedevere-bot commented May 24, 2023

Copy link

Copy Markdown

GH-104853 is a backport of this pull request to the 3.12 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.12 only security fixes label

May 24, 2023

bedevere-bot commented May 24, 2023

Copy link

Copy Markdown

GH-104853 is a backport of this pull request to the 3.12 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland commented May 24, 2023

Copy link

Copy Markdown

Contributor

I forgot to ask the obvious question: did you verify that the warning disappeared?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

corona10 added a commit that referenced this pull request

May 24, 2023


          [3.12] gh-101282: Enclose BOLT_APPLY_FLAGS value in double quotes (gh… (

b151660

gh-104853)

[3.12] gh-101282: Enclose BOLT_APPLY_FLAGS value in double quotes (gh-104752)
(cherry picked from commit c437851)

Reviewers

erlend-aasland

erlend-aasland approved these changes

ned-deily

Awaiting requested review from ned-deily

Uh oh!

There was an error while loading. Please reload this page.

Assignees

corona10

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

corona10 commented May 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

corona10 commented May 23, 2023

Uh oh!

erlend-aasland commented May 23, 2023

Uh oh!

Uh oh!

erlend-aasland left a comment

Choose a reason for hiding this comment

Uh oh!

bedevere-bot commented May 24, 2023

Uh oh!

erlend-aasland commented May 24, 2023

Uh oh!

miss-islington commented May 24, 2023

Uh oh!

miss-islington commented May 24, 2023

Uh oh!

bedevere-bot commented May 24, 2023

Uh oh!

bedevere-bot commented May 24, 2023

Uh oh!

erlend-aasland commented May 24, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

corona10 commented May 22, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.