GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-104719: IDLE - test existence of all tokenize references. by terryjreedy · Pull Request #104767 · python/cpython

Conversation

@terryjreedy

@terryjreedy terryjreedy commented May 22, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This was prompted when (temporary) removal of tokenize.tabsize broke IDLE without a CI failure.
Class editor.IndentSearcher contains all editor references to the tokenize module.
The 2 iomenu references cover those in pyshell, run, and runscript also.

  • Issue: IDLE is unable to open any .py files #104719

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
terryjreedy added 4 commits May 22, 2023 00:04
@terryjreedy
pythongh-104719: IDLE - test editor.IndentSearcher
446ddc4 
This class contains all editor references to tokenize module.
@terryjreedy
Add IndentSearcher test.
cb348d8
@terryjreedy
Add new coverage and generate TokenError.
1338a2a
@terryjreedy
Add minimal test for other tokenize names.
d3bac6c
@terryjreedy terryjreedy added the topic-IDLE label May 22, 2023
@terryjreedy terryjreedy self-assigned this May 22, 2023
@bedevere-bot bedevere-bot added the awaiting core review label May 22, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 22, 2023
IDLE is unable to open any .py files #104719
Closed
@Yhg1s
Merge branch 'main' into toktest
7828a83
JelleZijlstra
JelleZijlstra reviewed May 23, 2023
View reviewed changes
Comment thread Lib/idlelib/editor.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/idlelib/idle_test/test_iomenu.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
terryjreedy and others added 2 commits May 23, 2023 01:06
@terryjreedy @JelleZijlstra
Update Lib/idlelib/editor.py
c6f59fb 
Co-authored-by: Jelle Zijlstra <[email protected]>
@terryjreedy @JelleZijlstra
Update Lib/idlelib/idle_test/test_iomenu.py
0a99cf0 
Co-authored-by: Jelle Zijlstra <[email protected]>
@terryjreedy terryjreedy added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes and removed topic-IDLE labels May 23, 2023
terryjreedy added 5 commits May 23, 2023 17:20
@terryjreedy
Add blurb and IDLE news.
ec7388e
@terryjreedy
Merge remote-tracking branch 'upstream/main' into toktest
77f66be
@terryjreedy
Update merge.
7eb9e3c
@terryjreedy
Merge branch 'toktest' of https://github.com/terryjreedy/cpython into…
698d55d 
… toktest
@terryjreedy
Revert "Update merge."
bc197be 
This reverts commit 7eb9e3c.
@terryjreedy
terryjreedy enabled auto-merge (squash) May 23, 2023 21:34
@terryjreedy
Merge branch 'main' into toktest
1d616cc
@terryjreedy

terryjreedy commented May 24, 2023

Copy link
Copy Markdown
Member Author

@Yhg1s Can you as RM merge this? Address sanitizer had failed 4 times in a row because test_hashlib, test_importlib, and test_threading (X3) have altered the environment. Details on discord core-workflow. (Will rerun again
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood
Merge branch 'main' into toktest
d13b811
@terryjreedy
terryjreedy merged commit e561c09 into python:main May 24, 2023
@miss-islington

miss-islington commented May 24, 2023

Copy link
Copy Markdown
Contributor

Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label May 24, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 24, 2023
@terryjreedy @JelleZijlstra @miss-islington
pythongh-104719: IDLE - test existence of all tokenize references. (p…
1061d30 
…ythonGH-104767)

Class editor.IndentSearcher contains all editor references to tokenize module.
Module io tokenize reference cover those other modules.

(cherry picked from commit e561c09)

Co-authored-by: Terry Jan Reedy <[email protected]>
Co-authored-by: Jelle Zijlstra <[email protected]>
@bedevere-bot

bedevere-bot commented May 24, 2023

Copy link
Copy Markdown

GH-104844 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label May 24, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 24, 2023
@terryjreedy @JelleZijlstra @miss-islington
pythongh-104719: IDLE - test existence of all tokenize references. (p…
63336e2 
…ythonGH-104767)

Class editor.IndentSearcher contains all editor references to tokenize module.
Module io tokenize reference cover those other modules.

(cherry picked from commit e561c09)

Co-authored-by: Terry Jan Reedy <[email protected]>
Co-authored-by: Jelle Zijlstra <[email protected]>
@bedevere-bot

bedevere-bot commented May 24, 2023

Copy link
Copy Markdown

GH-104845 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label May 24, 2023
terryjreedy added a commit that referenced this pull request May 24, 2023
@miss-islington @terryjreedy @JelleZijlstra
[3.12] gh-104719: IDLE - test existence of all tokenize references. (G…
5e1799e 
…H-104767) (#104844)

gh-104719: IDLE - test existence of all tokenize references. (GH-104767)

Class editor.IndentSearcher contains all editor references to tokenize module.
Module io tokenize reference cover those other modules.

(cherry picked from commit e561c09)

Co-authored-by: Terry Jan Reedy <[email protected]>
Co-authored-by: Jelle Zijlstra <[email protected]>
terryjreedy added a commit that referenced this pull request May 24, 2023
@miss-islington @terryjreedy @JelleZijlstra
[3.11] gh-104719: IDLE - test existence of all tokenize references. (G…
22618a8 
…H-104767) (#104845)

gh-104719: IDLE - test existence of all tokenize references. (GH-104767)

Class editor.IndentSearcher contains all editor references to tokenize module.
Module io tokenize reference cover those other modules.

(cherry picked from commit e561c09)

Co-authored-by: Terry Jan Reedy <[email protected]>
Co-authored-by: Jelle Zijlstra <[email protected]>
@JelleZijlstra

JelleZijlstra commented May 24, 2023

Copy link
Copy Markdown
Member

The buildbot failure might be a bad interaction with #104846 which @pablogsal merged earlier.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra

JelleZijlstra commented May 24, 2023

Copy link
Copy Markdown
Member

Oh, seems like Pablo already fixed this in his PR?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@terryjreedy
terryjreedy deleted the toktest branch May 24, 2023 13:34
@python python deleted a comment from bedevere-bot May 24, 2023
@python python deleted a comment from bedevere-bot May 24, 2023
@python python deleted a comment from bedevere-bot May 24, 2023
@python python deleted a comment from bedevere-bot May 24, 2023
@terryjreedy terryjreedy mentioned this pull request May 24, 2023
[3.12] gh-104825: Remove implicit newline in the line attribute in tokens emitted in the tokenize module (GH-104846). #104850
Merged
@terryjreedy

terryjreedy commented May 24, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

From #104880 message. "Order of events:
Terry automerged new idlelib test into main.
Ms. I. made a 3.12 backport; tests passed.
Pablo merged the tokenize change with idlelib test fix into main. Pablo merged a 3.12 backport without the idle test fix as the backport of the latter had not yet been been merged. Terry merged the idlelib test backport. The new test failed on at least 4 3.12 buildbots because of the tokenize change. This PR backports the now needed idlelib test fix."
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
3.12 backport gh 105236 #105358
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@terryjreedy terryjreedy

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@terryjreedy @miss-islington @bedevere-bot @JelleZijlstra @Yhg1s @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.