GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-104497: Make tkinter test pass with tk 8.7 by terryjreedy · Pull Request #104789 · python/cpython

Conversation

@terryjreedy

@terryjreedy terryjreedy commented May 23, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

For test_widgets.MenuTest.test_configure_type, the options in the error message change to alphabetical order.

  • Issue: Tkinter: Tk 8.7 alphabetizes options in certain error messages #104497

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@terryjreedy
pythongh-104497: Make tkinter test pass with tk 8.7
ff8f707 
For test_widgets.MenuTest.test_configure_type, the options
in the error message change to alphabetical order.
@terryjreedy terryjreedy added tests Tests in the Lib/test dir skip news DO-NOT-MERGE needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels May 23, 2023
@terryjreedy
terryjreedy requested a review from serhiy-storchaka May 23, 2023 05:17
@terryjreedy terryjreedy self-assigned this May 23, 2023
@bedevere-bot bedevere-bot added the awaiting core review label May 23, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 23, 2023
Tkinter: Tk 8.7 alphabetizes options in certain error messages #104497
Closed
@terryjreedy

terryjreedy commented May 23, 2023

Copy link
Copy Markdown
Member Author

@chrstphrchvz please verify that this passes on 8.7.

@serhiy-storchaka I presume a root.destroy call is needed rather than merely deleting the python binding. If another test in the file ever needs a fix for 8.7 or 9.0, etc., fetching tk_version could be moved to the top of the file, or I could do so now if you prefer.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@terryjreedy

terryjreedy commented May 24, 2023

Copy link
Copy Markdown
Member Author

@chrstphrchvz Please verify that this run without error on 8.7.

@serhiy-storchaka If tk_ver were someday needed for another test, it could be moved to module level. I can do so now if you want.

I presume that explicit root.destroy is needed before exiting the function.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
chrstphrchvz
chrstphrchvz reviewed May 24, 2023
View reviewed changes

@chrstphrchvz chrstphrchvz left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that the test passes on Tk 8.7 with this change.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/test/test_tkinter/test_widgets.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/test_tkinter/test_widgets.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka
serhiy-storchaka reviewed May 24, 2023
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use widget.info_patchlevel() in 3.11+, or test.test_tkinter.support.tcl_version or test.test_tkinter.support.get_tk_patchlevel() in older versions.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
serhiy-storchaka
serhiy-storchaka reviewed May 24, 2023
View reviewed changes
Comment thread Lib/test/test_tkinter/test_widgets.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@terryjreedy @serhiy-storchaka
Update Lib/test/test_tkinter/test_widgets.py
ac16189 
Co-authored-by: Serhiy Storchaka <[email protected]>
@terryjreedy terryjreedy removed the DO-NOT-MERGE label May 27, 2023
@terryjreedy
terryjreedy enabled auto-merge (squash) May 27, 2023 19:03
@terryjreedy

terryjreedy commented May 27, 2023

Copy link
Copy Markdown
Member Author

This PR was written specifically as it is because this was the only known test failure when written. #104855 and #104856 report more is test_widget and widget_test. I will later list the alternatives I see in the first of those issues.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@terryjreedy
terryjreedy merged commit 897e716 into python:main May 27, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label May 27, 2023
@miss-islington

miss-islington commented May 27, 2023

Copy link
Copy Markdown
Contributor

Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented May 27, 2023

Copy link
Copy Markdown

GH-105028 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 27, 2023
@terryjreedy @serhiy-storchaka @miss-islington
pythongh-104497: Make tkinter test pass with tk 8.7 (pythonGH-104789)
3fdfdab 
* pythongh-104497: Make tkinter test pass with tk 8.7

For test_widgets.MenuTest.test_configure_type, the options
in the error message change to alphabetical order.

* Update Lib/test/test_tkinter/test_widgets.py

Co-authored-by: Serhiy Storchaka <[email protected]>

---------

(cherry picked from commit 897e716)

Co-authored-by: Terry Jan Reedy <[email protected]>
Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label May 27, 2023
@bedevere-bot

bedevere-bot commented May 27, 2023

Copy link
Copy Markdown

GH-105029 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label May 27, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 27, 2023
@terryjreedy @serhiy-storchaka @miss-islington
pythongh-104497: Make tkinter test pass with tk 8.7 (pythonGH-104789)
afe4b8d 
* pythongh-104497: Make tkinter test pass with tk 8.7

For test_widgets.MenuTest.test_configure_type, the options
in the error message change to alphabetical order.

* Update Lib/test/test_tkinter/test_widgets.py

Co-authored-by: Serhiy Storchaka <[email protected]>

---------

(cherry picked from commit 897e716)

Co-authored-by: Terry Jan Reedy <[email protected]>
Co-authored-by: Serhiy Storchaka <[email protected]>
terryjreedy added a commit that referenced this pull request May 27, 2023
@miss-islington @terryjreedy @serhiy-storchaka
[3.12] gh-104497: Make tkinter test pass with tk 8.7 (GH-104789) (#10…
5426ff1 
…5028)

For test_widgets.MenuTest.test_configure_type, the options
in the error message change to alphabetical order.
---------

(cherry picked from commit 897e716)

Co-authored-by: Terry Jan Reedy <[email protected]>
Co-authored-by: Serhiy Storchaka <[email protected]>
terryjreedy added a commit that referenced this pull request May 27, 2023
@miss-islington @terryjreedy @serhiy-storchaka
[3.11] gh-104497: Make tkinter test pass with tk 8.7 (GH-104789) (#10…
dcfa816 
…5029)

For test_widgets.MenuTest.test_configure_type, the options
in the error message change to alphabetical order.
---------

(cherry picked from commit 897e716)

Co-authored-by: Terry Jan Reedy <[email protected]>
Co-authored-by: Serhiy Storchaka <[email protected]>
@terryjreedy
terryjreedy deleted the tkalpha branch May 27, 2023 21:53
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
3.12 backport gh 105236 #105358
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments
+1 more reviewer
@chrstphrchvz chrstphrchvz chrstphrchvz left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@terryjreedy terryjreedy

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@terryjreedy @miss-islington @bedevere-bot @serhiy-storchaka @chrstphrchvz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.