GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-87891: Add ABI check to CI by encukou · Pull Request #104793 · python/cpython

Conversation

@encukou

@encukou encukou commented May 23, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Backport the workflow step and fix-ups:
    • [3.11] Add CI step to check changes in the exported ABI #92442 (e89c01e)
    • [3.11] Add an error message to the ABI-dump file check #94129 (0dadb22)
    • [3.11] gh-98548: Fix -ne shell operator spelling #98556 (194588d)
  • Remove ABI dump from gitignore
  • Add ABI dump generated in a ubuntu:22.04 container

cc @Yhg1s

📚 Documentation preview 📚: https://cpython-previews--104793.org.readthedocs.build/

  • Issue: Create a release branch ABI stability regression test #87891

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
pablogsal and others added 3 commits May 23, 2023 08:52
@pablogsal @sterliakov @encukou
[3.12] Add CI step to check changes in the exported ABI (python#92442)
1aeeebd 
Backport the workflow change and fix-ups:
- pythonGH-92442 (e89c01e)
- pythonGH-94129 (0dadb22)
- pythonGH-98556 (194588d)

Co-Authored-By: sterliakov <[email protected]>
@encukou
Remove ABI dump from gitignore
9d9a5d8
@encukou
Add ABI dump generated in a ubuntu:22.04 comtainer
0834f18
@encukou
encukou requested review from ezio-melotti and hugovk as code owners May 23, 2023 07:37
@bedevere-bot bedevere-bot added the awaiting core review label May 23, 2023
hugovk
hugovk reviewed May 23, 2023
View reviewed changes
Comment thread .github/workflows/build.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread .github/workflows/build.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread .github/workflows/build.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread .github/workflows/build.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread .github/workflows/build.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
hugovk
hugovk reviewed May 23, 2023
View reviewed changes
Comment thread .github/workflows/build.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
encukou and others added 2 commits May 23, 2023 09:55
@encukou
Use Ubuntu 22.04 (latest LTS & version in the devguide)
51a0e66
@encukou @hugovk
Version updates & typo fixes
a5d9ec0 
Co-authored-by: Hugo van Kemenade <[email protected]>
@encukou encukou added skip issue skip news labels May 23, 2023
@encukou encukou changed the title [3.12] Add ABI check to CI [3.12] gh-87891: Add ABI check to CI May 23, 2023
@encukou encukou removed the skip issue label May 23, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 23, 2023
Create a release branch ABI stability regression test #87891
Closed
@Yhg1s
Yhg1s merged commit b44beac into python:3.12 May 23, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label May 23, 2023
@arhadthedev arhadthedev mentioned this pull request May 23, 2023
ABI dump check needs to be added after branching python/release-tools#46
Open
@encukou
encukou deleted the 3.12-abicheck branch May 23, 2023 09:44
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
3.12 backport gh 105236 #105358
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk left review comments
@Yhg1s Yhg1s Yhg1s left review comments
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@encukou @hugovk @Yhg1s @bedevere-bot @pablogsal
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.