GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] gh-98548: Fix `-ne` shell operator spelling by sterliakov · Pull Request #98556 · python/cpython

Conversation

@sterliakov

@sterliakov sterliakov commented Oct 22, 2022

Copy link
Copy Markdown
Contributor

gh-98548: Workflow not equal operator spelling

This shell operator should be spelled as -ne, not as -neq. All shell binary operators are two symbols long.

This bug is present on 3.10 and 3.11 branches only.

This follows #98555 for another affected branch.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sterliakov
Fix -ne shell operator spelling
1feb7ff
@sterliakov
sterliakov requested a review from ezio-melotti as a code owner October 22, 2022 20:03
@bedevere-bot bedevere-bot added the awaiting review label Oct 22, 2022
@bedevere-bot

bedevere-bot commented Oct 22, 2022

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood AlexWaygood added the skip news label Oct 22, 2022
hauntsaninja
hauntsaninja reviewed Oct 23, 2022
View reviewed changes

@hauntsaninja hauntsaninja left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this!

Here is an example workflow run affected: https://github.com/python/cpython/actions/runs/3293756628/jobs/5430563962
That said, I'm not sure this is enough of a fix, because I think Github Actions runs with bash -e. So I think we'd never get to this anyway? One option would be to use || (echo ... ; exit 1) or something

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hauntsaninja hauntsaninja mentioned this pull request Oct 23, 2022
[3.10] gh-98548: Fix -ne shell operator spelling #98555
Merged
@sterliakov

sterliakov commented Oct 24, 2022

Copy link
Copy Markdown
Contributor Author

Since the command expected to fail is short enough, maybe just

if ! make check-abidump; then
    echo ...
fi

is sufficient? The if and until conditions are not considered failing for -e. Yes, gihub actions use set -e (or bash -e, not sure about this) to fail on first failing step.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sterliakov
Keep in mind set -e
49623da
@sterliakov
sterliakov requested review from hauntsaninja and removed request for ezio-melotti October 24, 2022 10:09
hauntsaninja
hauntsaninja approved these changes Oct 25, 2022
View reviewed changes

@hauntsaninja hauntsaninja left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good to me. Want to update the 3.10 backport #98555 as well? :-) cc @JelleZijlstra

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Oct 25, 2022
@JelleZijlstra JelleZijlstra self-assigned this Oct 25, 2022
@sterliakov

sterliakov commented Oct 25, 2022

Copy link
Copy Markdown
Contributor Author

Updated #98555 too.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ambv
ambv merged commit 194588d into python:3.11 Oct 28, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label Oct 28, 2022
encukou pushed a commit to encukou/cpython that referenced this pull request May 23, 2023
@pablogsal @sterliakov @encukou
[3.12] Add CI step to check changes in the exported ABI (python#92442)
1aeeebd 
Backport the workflow change and fix-ups:
- pythonGH-92442 (e89c01e)
- pythonGH-94129 (0dadb22)
- pythonGH-98556 (194588d)

Co-Authored-By: sterliakov <[email protected]>
@encukou encukou mentioned this pull request May 23, 2023
[3.12] gh-87891: Add ABI check to CI #104793
Merged
Yhg1s pushed a commit that referenced this pull request May 23, 2023
@encukou @sterliakov
@hugovk @pablogsal
[3.12] gh-87891: Add ABI check to CI (#104793)
b44beac 
Backport the workflow change and fix-ups:
- GH-92442 (e89c01e)
- GH-94129 (0dadb22)
- GH-98556 (194588d)

Co-Authored-By: sterliakov <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Pablo Galindo Salgado <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@JelleZijlstra JelleZijlstra

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@sterliakov @bedevere-bot @hauntsaninja @ambv @JelleZijlstra @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.