GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-104797: Allow Protocols to inherit from collections.abc.Buffer by JelleZijlstra · Pull Request #104827 · python/cpython

Conversation

@JelleZijlstra

@JelleZijlstra JelleZijlstra commented May 24, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Fixes #104797

  • Issue: Cannot use multiple inheritance with collections.abc.Buffer and typing.Protocol #104797

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JelleZijlstra
Allow Protocols to inherit from collections.abc.Buffer
0b19f90
@JelleZijlstra JelleZijlstra added topic-typing needs backport to 3.12 only security fixes labels May 24, 2023
@bedevere-bot bedevere-bot added the awaiting core review label May 24, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 24, 2023
Cannot use multiple inheritance with collections.abc.Buffer and typing.Protocol #104797
Closed
@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label May 24, 2023
@JelleZijlstra
Need more than just news
b1c838f
@JelleZijlstra
JelleZijlstra requested review from AlexWaygood, Fidget-Spinner and gvanrossum as code owners May 24, 2023 00:46
AlexWaygood
AlexWaygood approved these changes May 24, 2023
View reviewed changes

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels May 24, 2023
@AlexWaygood
AlexWaygood enabled auto-merge (squash) May 24, 2023 06:23
@AlexWaygood
Merge branch 'main' into bufpro
3253057
@AlexWaygood
AlexWaygood merged commit c0ab7d4 into python:main May 24, 2023
@miss-islington

miss-islington commented May 24, 2023

Copy link
Copy Markdown
Contributor

Thanks @JelleZijlstra for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label May 24, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 24, 2023
@JelleZijlstra @miss-islington
pythongh-104797: Allow Protocols to inherit from collections.abc.Buff…
42a05db 
…er (pythonGH-104827)

(cherry picked from commit c0ab7d4)

Co-authored-by: Jelle Zijlstra <[email protected]>
@bedevere-bot

bedevere-bot commented May 24, 2023

Copy link
Copy Markdown

GH-104841 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label May 24, 2023
AlexWaygood pushed a commit that referenced this pull request May 24, 2023
@miss-islington @JelleZijlstra
[3.12] gh-104797: Allow Protocols to inherit from collections.abc.Buf…
d10d1e3 
…fer (GH-104827) (#104841)

gh-104797: Allow Protocols to inherit from collections.abc.Buffer (GH-104827)
(cherry picked from commit c0ab7d4)

Co-authored-by: Jelle Zijlstra <[email protected]>
@bedevere-bot

This comment was marked as off-topic.

Sign in to view
@AlexWaygood AlexWaygood mentioned this pull request Jun 4, 2023
Allow Protocols to inherit from typing_extensions.Buffer or collections.abc.Buffer python/typing_extensions#220
Merged
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
3.12 backport gh 105236 #105358
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes
@gvanrossum gvanrossum Awaiting requested review from gvanrossum
@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir topic-typing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cannot use multiple inheritance with collections.abc.Buffer and typing.Protocol

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@JelleZijlstra @miss-islington @bedevere-bot @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.