GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-104835: Remove unittest's deprecated getTestCaseNames, makeSuite, findTestCases by hugovk · Pull Request #104836 · python/cpython

Conversation

@hugovk

@hugovk hugovk commented May 24, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Closes #104835.

Remove unittest's findTestCases, makeSuite and getTestCaseNames, deprecated in Python 3.11 in gh-50096 and scheduled for removal in 3.13.

Use unittest.TestLoader methods instead:

  • unittest.TestLoader.loadTestsFromModule
  • unittest.TestLoader.loadTestsFromTestCase
  • unittest.TestLoader.getTestCaseNames
  • Issue: Remove unittest's deprecated getTestCaseNames, makeSuite, findTestCases #104835

📚 Documentation preview 📚: https://cpython-previews--104836.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@hugovk
Remove unittest's getTestCaseNames, makeSuite, findTestCases, depreca…
a30f619
…ted in Python 3.11
@hugovk hugovk added the stdlib Standard Library Python modules in the Lib/ directory label May 24, 2023
@bedevere-bot bedevere-bot added the awaiting core review label May 24, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 24, 2023
Remove unittest's deprecated getTestCaseNames, makeSuite, findTestCases #104835
Closed
@hugovk hugovk mentioned this pull request May 24, 2023
Deprecate obsolete functions in unittest #50096
Closed
@hugovk
Merge branch 'main' into rm-unittest-deprecations
0b168cd
JelleZijlstra
JelleZijlstra approved these changes May 24, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels May 24, 2023
@hugovk
Merge branch 'main' into rm-unittest-deprecations
b2e57e5
@hugovk
hugovk enabled auto-merge (squash) May 24, 2023 21:02
@hugovk
hugovk merged commit b1cb30e into python:main May 24, 2023
@hugovk
hugovk deleted the rm-unittest-deprecations branch May 24, 2023 21:16
@bedevere-bot bedevere-bot removed the awaiting merge label May 24, 2023
markmentovai added a commit to markmentovai/pyftdi that referenced this pull request Nov 4, 2024
@markmentovai
tests: Fix for Python 3.13 (unittest.makeSuite was removed)
426e1ab
```
ImportError while importing test module '…/pyftdi/pyftdi/tests/toolsimport.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
…/lib/python3.13/importlib/__init__.py:88: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
pyftdi/tests/toolsimport.py:16: in <module>
    from unittest import TestCase, TestSuite, makeSuite, main as ut_main
E   ImportError: cannot import name 'makeSuite' from 'unittest' (…/lib/python3.13/unittest/__init__.py)
```

python/cpython#104835
python/cpython#104836
python/cpython@b1cb30e
https://docs.python.org/3/whatsnew/3.13.html#unittest
@markmentovai markmentovai mentioned this pull request Nov 4, 2024
tests: Fix for Python 3.13 (unittest.makeSuite was removed) eblot/pyftdi#387
Merged
eblot pushed a commit to eblot/pyftdi that referenced this pull request Nov 19, 2024
@markmentovai @eblot
tests: Fix for Python 3.13 (unittest.makeSuite was removed)
0017c01
```
ImportError while importing test module '…/pyftdi/pyftdi/tests/toolsimport.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
…/lib/python3.13/importlib/__init__.py:88: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
pyftdi/tests/toolsimport.py:16: in <module>
    from unittest import TestCase, TestSuite, makeSuite, main as ut_main
E   ImportError: cannot import name 'makeSuite' from 'unittest' (…/lib/python3.13/unittest/__init__.py)
```

python/cpython#104835
python/cpython#104836
python/cpython@b1cb30e
https://docs.python.org/3/whatsnew/3.13.html#unittest
@daskol daskol mentioned this pull request Dec 27, 2024
Failed in the test process in Python 3.13 google-deepmind/chex#371
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

stdlib Standard Library Python modules in the Lib/ directory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove unittest's deprecated getTestCaseNames, makeSuite, findTestCases

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@hugovk @JelleZijlstra @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.