GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-104773: PEP 594: Remove the pipes module by vstinner · Pull Request #104848 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented May 24, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: PEP 594: Remove stdlib modules scheduled for deletion in Python 3.13 #104773

📚 Documentation preview 📚: https://cpython-previews--104848.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-bot bedevere-bot added the awaiting core review label May 24, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 24, 2023
PEP 594: Remove stdlib modules scheduled for deletion in Python 3.13 #104773
Closed
19 tasks done
@vstinner
pythongh-104773: PEP 594: Remove the pipes module
f5e9995
@vstinner
vstinner force-pushed the remove_pipes branch from 72c00a6 to f5e9995 Compare May 24, 2023 09:46
@vstinner vstinner changed the title gh-104773: PEP 594: Remove pipes module gh-104773: PEP 594: Remove the pipes module May 24, 2023
@hugovk

hugovk commented May 24, 2023

Copy link
Copy Markdown
Member

The doctest failure is unrelated, here's a PR to fix it: #104852

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

hugovk
hugovk approved these changes May 24, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels May 24, 2023
@AlexWaygood
Merge branch 'main' into remove_pipes
dcb6683
@vstinner

vstinner commented May 24, 2023

Copy link
Copy Markdown
Member Author

@AlexWaygood: Why did you merged the branch 'main' into remove_pipes? I created this PR 49 minutes ago. Do you expect regressions since main changed in the meanwhile? I was awaiting CI tests to complete, and with this merge I have to wait 30 minutes again :-(

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@hugovk

hugovk commented May 24, 2023

Copy link
Copy Markdown
Member

I expect it's to include the doctest fix #104852 from main, so we can get a nice clean (green) slate here.

AlexWaygood reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@AlexWaygood

AlexWaygood commented May 24, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

@vstinner sorry if I was unhelpful. The doctest CI check was failing on this PR for an unrelated reason; after Hugo merged his fix for the doctest failure into main, I thought I could retrigger the check for you here by merging main into this PR branch. But, since it wasn't a "required" check, you probably could have merged the PR anyway, despite the CI check being red. My bad — sorry again :-)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@hugovk

hugovk commented May 24, 2023

Copy link
Copy Markdown
Member

By the way, we've now made available GitHub's "Enable auto-merge" feature for this repo, so this could be a good opportunity to give it a spin:

https://devguide.python.org/getting-started/git-boot-camp/#accepting-and-merging-a-pull-request

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner

vstinner commented May 24, 2023

Copy link
Copy Markdown
Member Author

The doctest CI check was failing on this PR

Oh, I didn't see. In that case, thank you :-) I was just surprised to see a merge without any explanation.

AlexWaygood reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@AlexWaygood

AlexWaygood commented May 24, 2023

Copy link
Copy Markdown
Member

I was just surprised to see a merge without any explanation.

Apologies — I'll explain my actions next time 😄

vstinner reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner
vstinner merged commit a4b7e9d into python:main May 24, 2023
@vstinner
vstinner deleted the remove_pipes branch May 24, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@vstinner @hugovk @AlexWaygood @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.