GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-102856: Add missing quote to fix doctest by hugovk · Pull Request #104852 · python/cpython

Conversation

@hugovk

@hugovk hugovk commented May 24, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
Document: whatsnew/3.12
-----------------------
**********************************************************************
File "whatsnew/3.12.rst", line ?, in default
Failed example:
    f"This is the playlist: {", ".join(songs)}"
Expected:
    'This is the playlist: Take me back to Eden, Alkaline, Ascensionism
Got:
    'This is the playlist: Take me back to Eden, Alkaline, Ascensionism'
**********************************************************************
1 items had failures:
   1 of  12 in default
12 tests in 1 items.
11 passed and 1 failed.
***Test Failed*** 1 failures.

https://github.com/python/cpython/actions/runs/5066957137/jobs/9097400760

Introduced in #104824.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@hugovk
Add missing quote to fix doctest
213aba7
@bedevere-bot bedevere-bot added awaiting core review docs Documentation in the Doc dir skip news labels May 24, 2023
@hugovk hugovk changed the title Add missing quote to fix doctest gh-102856: Add missing quote to fix doctest May 24, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 24, 2023
PEP 701 – Syntactic formalization of f-strings #102856
Closed
4 tasks done
@hugovk hugovk added the needs backport to 3.12 only security fixes label May 24, 2023
This was referenced May 24, 2023
gh-102856: Add changes related to PEP 701 in 3.12 What's New docs #104824
Merged
gh-104773: PEP 594: Remove the pipes module #104848
Merged
AlexWaygood
AlexWaygood approved these changes May 24, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels May 24, 2023
@hugovk
hugovk merged commit 3e97c00 into python:main May 24, 2023
@hugovk
hugovk deleted the fix-docs branch May 24, 2023 10:21
@miss-islington

miss-islington commented May 24, 2023

Copy link
Copy Markdown
Contributor

Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the awaiting merge label May 24, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 24, 2023
@hugovk @miss-islington
pythongh-102856: Add missing quote to fix doctest (pythonGH-104852)
ec62b10
(cherry picked from commit 3e97c00)

Co-authored-by: Hugo van Kemenade <[email protected]>
@bedevere-bot

bedevere-bot commented May 24, 2023

Copy link
Copy Markdown

GH-104854 is a backport of this pull request to the 3.12 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label May 24, 2023
hugovk added a commit that referenced this pull request May 24, 2023
@miss-islington @hugovk
[3.12] gh-102856: Add missing quote to fix doctest (GH-104852) (#104854)
2d685ec
Co-authored-by: Hugo van Kemenade <[email protected]>
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
3.12 backport gh 105236 #105358
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@hugovk @miss-islington @bedevere-bot @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.