GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-102856: Update "Formatted string literals" docs section after PEP701 by lysnikolaou · Pull Request #104861 · python/cpython

Conversation

@lysnikolaou

@lysnikolaou lysnikolaou commented May 24, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: PEP 701 – Syntactic formalization of f-strings #102856

📚 Documentation preview 📚: https://cpython-previews--104861.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@lysnikolaou
pythongh-102856: Update "Formatted string literals" docs section afte…
298a693 
…r PEP701
@bedevere-bot bedevere-bot added the awaiting core review label May 24, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 24, 2023
PEP 701 – Syntactic formalization of f-strings #102856
Closed
4 tasks done
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news labels May 24, 2023
@lysnikolaou
lysnikolaou requested a review from pablogsal May 24, 2023 12:13
@pablogsal

pablogsal commented May 24, 2023

Copy link
Copy Markdown
Member

I think we need to fix also the "grammar" that is included here and substitute that for the PEG grammar
Eclips4 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal

pablogsal commented May 24, 2023

Copy link
Copy Markdown
Member

image

I mean this one
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lysnikolaou

lysnikolaou commented May 24, 2023

Copy link
Copy Markdown
Member Author

I think we need to fix also the "grammar" that is included here and substitute that for the PEG grammar

Not sure about that. The existing grammar feels easier to read. Since the purpose of this is to give an overview of what can go into an f-string, I don't think we should over-complicate stuff with FSTRING_START, FSTRING_END etc.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal

pablogsal commented May 24, 2023

Copy link
Copy Markdown
Member

Hummmm IIRC that grammar is slightly incorrect or it was missing some details. Check it out and if you are happy with it then let's keep it
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lysnikolaou

lysnikolaou commented May 24, 2023

Copy link
Copy Markdown
Member Author

I briefly compared it with our version in the PEG and it seems okay to me. If you're also okay with it, we can merge.
pablogsal reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pablogsal
pablogsal approved these changes May 24, 2023
View reviewed changes

@pablogsal pablogsal left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Great work!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels May 24, 2023
@lysnikolaou lysnikolaou added the needs backport to 3.12 only security fixes label May 24, 2023
@lysnikolaou
lysnikolaou merged commit 8e5b3b9 into python:main May 24, 2023
@miss-islington

miss-islington commented May 24, 2023

Copy link
Copy Markdown
Contributor

Thanks @lysnikolaou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label May 24, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 24, 2023
@lysnikolaou @miss-islington
pythongh-102856: Update "Formatted string literals" docs section afte…
e867088 
…r PEP701 (pythonGH-104861)

(cherry picked from commit 8e5b3b9)

Co-authored-by: Lysandros Nikolaou <[email protected]>
@bedevere-bot

bedevere-bot commented May 24, 2023

Copy link
Copy Markdown

GH-104865 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label May 24, 2023
lysnikolaou added a commit that referenced this pull request May 24, 2023
@miss-islington @lysnikolaou
[3.12] gh-102856: Update "Formatted string literals" docs section aft…
25890eb 
…er PEP701 (GH-104861) (#104865)

(cherry picked from commit 8e5b3b9)

Co-authored-by: Lysandros Nikolaou <[email protected]>
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
3.12 backport gh 105236 #105358
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@lysnikolaou @pablogsal @miss-islington @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.