GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-104866: Tokenize should emit NEWLINE after exiting block with comment (GH-104870) by miss-islington · Pull Request #104872 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented May 24, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit c90a862)

Co-authored-by: Lysandros Nikolaou [email protected]

  • Issue: inspect.getsourcelines() is buggy on 3.12 #104866

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@lysnikolaou @miss-islington
pythongh-104866: Tokenize should emit NEWLINE after exiting block wit…
3c3ea89 
…h comment (pythonGH-104870)

(cherry picked from commit c90a862)

Co-authored-by: Lysandros Nikolaou <[email protected]>
@miss-islington
miss-islington requested review from lysnikolaou and pablogsal as code owners May 24, 2023 16:18
@bedevere-bot bedevere-bot added the awaiting review label May 24, 2023
This was referenced May 24, 2023
inspect.getsourcelines() is buggy on 3.12 #104866
Closed
gh-104866: Tokenize should emit NEWLINE after exiting block with comment #104870
Merged
@bedevere-bot bedevere-bot added the skip news label May 24, 2023
pablogsal
pablogsal approved these changes May 24, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels May 24, 2023
@lysnikolaou

lysnikolaou commented May 24, 2023

Copy link
Copy Markdown
Member

@pablogsal @terryjreedy test_idle fails on 3.12 with this. I haven't exactly kept up with what happened there, so it's a bit unclear what we should do about it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@terryjreedy
Merge branch '3.12' into backport-c90a862-3.12
d855e89
@terryjreedy

terryjreedy commented May 24, 2023

Copy link
Copy Markdown
Member

Test failures at least mostly due to tokenizer - idlelib criss-crossed backports snafu. Rerunning after updating to get patch just merged.
lysnikolaou reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@terryjreedy
terryjreedy merged commit ddc29c8 into python:3.12 May 24, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label May 24, 2023
@miss-islington
miss-islington deleted the backport-c90a862-3.12 branch May 24, 2023 18:42
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
3.12 backport gh 105236 #105358
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@miss-islington @lysnikolaou @terryjreedy @pablogsal @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.