GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-104866: Tokenize should emit NEWLINE after exiting block with comment by lysnikolaou · Pull Request #104870 · python/cpython

Conversation

@lysnikolaou

@lysnikolaou lysnikolaou commented May 24, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: inspect.getsourcelines() is buggy on 3.12 #104866

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@lysnikolaou
pythongh-104866: Tokenize should emit NEWLINE after exiting block wit…
be2eff3 
…h comment
@lysnikolaou
lysnikolaou requested a review from pablogsal as a code owner May 24, 2023 15:44
@bedevere-bot bedevere-bot added the awaiting core review label May 24, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 24, 2023
inspect.getsourcelines() is buggy on 3.12 #104866
Closed
@lysnikolaou lysnikolaou added skip news needs backport to 3.12 only security fixes labels May 24, 2023
pablogsal
pablogsal approved these changes May 24, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels May 24, 2023
@pablogsal

pablogsal commented May 24, 2023

Copy link
Copy Markdown
Member

Good catch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal
pablogsal merged commit c90a862 into python:main May 24, 2023
@miss-islington

miss-islington commented May 24, 2023

Copy link
Copy Markdown
Contributor

Thanks @lysnikolaou for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label May 24, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 24, 2023
@lysnikolaou @miss-islington
pythongh-104866: Tokenize should emit NEWLINE after exiting block wit…
3c3ea89 
…h comment (pythonGH-104870)

(cherry picked from commit c90a862)

Co-authored-by: Lysandros Nikolaou <[email protected]>
@bedevere-bot

bedevere-bot commented May 24, 2023

Copy link
Copy Markdown

GH-104872 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label May 24, 2023
terryjreedy pushed a commit that referenced this pull request May 24, 2023
@miss-islington @lysnikolaou
[3.12] gh-104866: Tokenize should emit NEWLINE after exiting block wi…
ddc29c8 
…th comment (GH-104870) (#104872)

gh-104866: Tokenize should emit NEWLINE after exiting block with comment (GH-104870)
(cherry picked from commit c90a862)

Co-authored-by: Lysandros Nikolaou <[email protected]>
@pablogsal pablogsal mentioned this pull request May 25, 2023
Tokenizer module does not handle backslash characters correctly #90432
Closed
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
3.12 backport gh 105236 #105358
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@lysnikolaou @pablogsal @miss-islington @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.