GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-104879: Fix TypeAliasType.__module__ in exec() by JelleZijlstra · Pull Request #104881 · python/cpython

Conversation

@JelleZijlstra

@JelleZijlstra JelleZijlstra commented May 24, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: TypeAliasType.__module__ can segfault #104879

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JelleZijlstra
Fix TypeAliasType.__module__ in exec()
a6e5d5e
@JelleZijlstra JelleZijlstra added the needs backport to 3.12 only security fixes label May 24, 2023
@JelleZijlstra
JelleZijlstra requested review from AlexWaygood, Fidget-Spinner, gvanrossum and markshannon as code owners May 24, 2023 17:20
@bedevere-bot bedevere-bot added the awaiting core review label May 24, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 24, 2023
TypeAliasType.__module__ can segfault #104879
Closed
JelleZijlstra
JelleZijlstra commented May 24, 2023
View reviewed changes
Comment thread Lib/test/test_typing.py
self.assertIs(T.__infer_variance__, False)
self.assertEqual(T.__module__, __name__)

def test_basic_with_exec(self):

@JelleZijlstra JelleZijlstra May 24, 2023

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests already passed, but adding them here for completeness

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JelleZijlstra JelleZijlstra added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label May 24, 2023
@bedevere-bot

bedevere-bot commented May 24, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @JelleZijlstra for commit a6e5d5e 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label May 24, 2023
sunmy2019
sunmy2019 approved these changes May 24, 2023
View reviewed changes
Eclips4
Eclips4 approved these changes May 24, 2023
View reviewed changes
@JelleZijlstra
JelleZijlstra merged commit fe77a99 into python:main May 24, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label May 24, 2023
@miss-islington

miss-islington commented May 24, 2023

Copy link
Copy Markdown
Contributor

Thanks @JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra
JelleZijlstra deleted the tatmod branch May 24, 2023 18:48
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 24, 2023
@JelleZijlstra @miss-islington
pythongh-104879: Fix TypeAliasType.__module__ in exec() (pythonGH-104881
79b6101 
)

(cherry picked from commit fe77a99)

Co-authored-by: Jelle Zijlstra <[email protected]>
@bedevere-bot

bedevere-bot commented May 24, 2023

Copy link
Copy Markdown

GH-104890 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label May 24, 2023
JelleZijlstra added a commit that referenced this pull request May 24, 2023
@miss-islington @JelleZijlstra
[3.12] gh-104879: Fix TypeAliasType.__module__ in exec() (GH-104881) (#…
b670214 
…104890)

(cherry picked from commit fe77a99)

Co-authored-by: Jelle Zijlstra <[email protected]>
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
3.12 backport gh 105236 #105358
Closed
@JelleZijlstra
JelleZijlstra restored the tatmod branch September 10, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sunmy2019 sunmy2019 sunmy2019 approved these changes
@Eclips4 Eclips4 Eclips4 approved these changes
@gvanrossum gvanrossum Awaiting requested review from gvanrossum
@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner
@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood AlexWaygood is a code owner
@markshannon markshannon Awaiting requested review from markshannon

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@JelleZijlstra @bedevere-bot @miss-islington @sunmy2019 @Eclips4
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.