GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-104924: Fix `read()able` in `http.client` log messages by arhadthedev · Pull Request #104926 · python/cpython

Conversation

arhadthedev commented May 25, 2023 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

https://github.com/search?q=repo%3Apython%2Fcpython%20read()able&type=code shows no other occurrence of this typo.

Issue: "sendIng a read()able" as error message in /Lib/http/client.py #104924

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

LyingDalai reacted with thumbs up emoji

All reactions

👍 1 reaction


          Fix read()able in http.client docstrings

c284605

arhadthedev added docs

Documentation in the Doc dir

skip news needs backport to 3.11

only security fixes

needs backport to 3.12 only security fixes labels

May 25, 2023

bedevere-bot added the awaiting review label

May 25, 2023

bedevere-bot mentioned this pull request

May 25, 2023

"sendIng a read()able" as error message in /Lib/http/client.py #104924

Closed

gaogaotiantian requested changes

May 25, 2023

View reviewed changes

gaogaotiantian left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think sendIng is an obvious typo. On line 1057, from some brief reading, it's not "sending" a readable, but "reading" from a readable(as indicated by the function name).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

arhadthedev reacted with thumbs up emoji

All reactions

👍 1 reaction

Comment thread

Lib/http/client.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Lib/http/client.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot added awaiting core review and removed awaiting review labels

May 25, 2023


          sendIng -> reading

644722d

Co-authored-by: Tian Gao <[email protected]>

gaogaotiantian approved these changes

May 25, 2023

View reviewed changes

Eclips4 mentioned this pull request

May 25, 2023

#104924 issue: update Fixed typo #104928

Closed

LyingDalai commented May 25, 2023

Copy link

Copy Markdown

I have looked for any related typo with “Ing the read()”. I know PyCharm can make funny replacements but I still haven’t found where this would come from.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

corona10 approved these changes

May 26, 2023

View reviewed changes

corona10 left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-bot added awaiting merge and removed awaiting core review labels

May 26, 2023

corona10 merged commit 6c81d75 into python:main

May 26, 2023

bedevere-bot removed the awaiting merge label

May 26, 2023

miss-islington commented May 26, 2023

Copy link

Copy Markdown

Contributor

Thanks @arhadthedev for the PR, and @corona10 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

May 26, 2023


          pythongh-104924: Fix read()able in http.client log messages (pyth…

8ec8ba9

…ongh-104926)

(cherry picked from commit 6c81d75)

Co-authored-by: Oleg Iarygin <[email protected]>

bedevere-bot commented May 26, 2023

Copy link

Copy Markdown

GH-104970 is a backport of this pull request to the 3.12 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.12 only security fixes label

May 26, 2023

bedevere-bot commented May 26, 2023

Copy link

Copy Markdown

GH-104971 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.11 only security fixes label

May 26, 2023

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

May 26, 2023


          pythongh-104924: Fix read()able in http.client log messages (pyth…

…ongh-104926)

(cherry picked from commit 6c81d75)

Co-authored-by: Oleg Iarygin <[email protected]>

arhadthedev deleted the http-read-able branch

May 26, 2023 11:53

corona10 pushed a commit that referenced this pull request

May 26, 2023


          [3.11] gh-104924: Fix read()able in http.client log messages (gh-…

f585ed1

…104926) (gh-104971)

gh-104924: Fix `read()able` in `http.client` log messages (gh-104926)
(cherry picked from commit 6c81d75)

Co-authored-by: Oleg Iarygin <[email protected]>

corona10 pushed a commit that referenced this pull request

May 26, 2023


          [3.12] gh-104924: Fix read()able in http.client log messages (gh-…

83bdfa4

…104926) (gh-104970)

gh-104924: Fix `read()able` in `http.client` log messages (gh-104926)
(cherry picked from commit 6c81d75)

Co-authored-by: Oleg Iarygin <[email protected]>

erlend-aasland mentioned this pull request

Jun 6, 2023

3.12 backport gh 105236 #105358

Closed

Reviewers

corona10

corona10 approved these changes

gaogaotiantian

gaogaotiantian approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs

Documentation in the Doc dir

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

arhadthedev commented May 25, 2023 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gaogaotiantian left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

LyingDalai commented May 25, 2023

Uh oh!

corona10 left a comment

Choose a reason for hiding this comment

Uh oh!

miss-islington commented May 26, 2023

Uh oh!

bedevere-bot commented May 26, 2023

Uh oh!

bedevere-bot commented May 26, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

arhadthedev commented May 25, 2023 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.