GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Build docs as part of the MSI test by zooba · Pull Request #104929 · python/cpython

Conversation

@zooba

@zooba zooba commented May 25, 2023

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@zooba
Build docs as part of the MSI test
728011b
@zooba zooba added tests Tests in the Lib/test dir skip issue skip news labels May 25, 2023
@zooba
zooba requested review from ezio-melotti and hugovk as code owners May 25, 2023 11:48
@bedevere-bot bedevere-bot added the awaiting core review label May 25, 2023
@zooba
Also test when script changes
b0e3369
@zooba zooba mentioned this pull request May 25, 2023
gh-75552: Remove deprecated tkinter.tix module #104902
Merged
@zooba
zooba enabled auto-merge (squash) May 25, 2023 11:50
@zooba
Fix Tools/msi/build.bat to correctly set the exit code
eba426c
@zooba
zooba disabled auto-merge May 25, 2023 12:02
@zooba
zooba requested a review from a team as a code owner May 25, 2023 12:02
@zooba
zooba merged commit 569b2b8 into python:main May 25, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label May 25, 2023
@zooba zooba added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels May 25, 2023
@miss-islington

miss-islington commented May 25, 2023

Copy link
Copy Markdown
Contributor

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented May 25, 2023

Copy link
Copy Markdown
Contributor

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zooba
zooba deleted the msitest branch May 25, 2023 15:17
@miss-islington

miss-islington commented May 25, 2023

Copy link
Copy Markdown
Contributor

Sorry, @zooba, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 569b2b8d612354062b8679d2d3f44f7ee03e66c2 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned zooba May 25, 2023
@miss-islington

miss-islington commented May 25, 2023

Copy link
Copy Markdown
Contributor

Sorry @zooba, I had trouble checking out the 3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 569b2b8d612354062b8679d2d3f44f7ee03e66c2 3.12
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zooba zooba added needs backport to 3.12 only security fixes and removed needs backport to 3.12 only security fixes labels May 25, 2023
@miss-islington

miss-islington commented May 25, 2023

Copy link
Copy Markdown
Contributor

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 25, 2023
@zooba @miss-islington
Improves the Windows MSI test run on PR (pythonGH-104929)
ca15e6a 
Correctly set the exit code when builds fail
Also build docs as part of the test
(cherry picked from commit 569b2b8)

Co-authored-by: Steve Dower <[email protected]>
@bedevere-bot

bedevere-bot commented May 25, 2023

Copy link
Copy Markdown

GH-104934 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label May 25, 2023
zooba added a commit that referenced this pull request May 25, 2023
@miss-islington @zooba
Improves the Windows MSI test run on PR (GH-104929)
d176f78 
Correctly set the exit code when builds fail
Also build docs as part of the test
(cherry picked from commit 569b2b8)

Co-authored-by: Steve Dower <[email protected]>
@bedevere-bot

bedevere-bot commented May 25, 2023

Copy link
Copy Markdown

GH-104940 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
zooba added a commit that referenced this pull request May 25, 2023
@zooba
[3.10] Improves the Windows MSI test run on PR (GH-104929)
f22ddbf 
Correctly set the exit code when builds fail
Also build docs as part of the test
zware
zware reviewed May 25, 2023
View reviewed changes

@zware zware left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the fact :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
3.12 backport gh 105236 #105358
Closed
@hugovk hugovk removed the needs backport to 3.11 only security fixes label Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zware zware zware left review comments
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner
@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@zooba zooba

Labels

skip issue skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@zooba @miss-islington @bedevere-bot @zware @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.