GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix indentation in `json.AttrDict` REPL example by AlexWaygood · Pull Request #104930 · python/cpython

Conversation

@AlexWaygood

@AlexWaygood AlexWaygood commented May 25, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This is causing the docs to be rendered incorrectly.

https://docs.python.org/3.12/library/json.html#json.AttrDict

Screenshot of current rendering

image

📚 Documentation preview 📚: https://cpython-previews--104930.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AlexWaygood
Fix indentation in json.AttrDict REPL example
cbfcfe5 
This is causing the docs to be rendered incorrectly.
@AlexWaygood AlexWaygood added skip issue skip news needs backport to 3.12 only security fixes labels May 25, 2023
@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label May 25, 2023
@AlexWaygood

AlexWaygood commented May 25, 2023

Copy link
Copy Markdown
Member Author

Confirmed that this fixes the rendering issue. Docs preview: https://cpython-previews--104930.org.readthedocs.build/en/104930/library/json.html#json.AttrDict
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood
AlexWaygood marked this pull request as ready for review May 25, 2023 12:41
@bedevere-bot bedevere-bot added the awaiting core review label May 25, 2023
@AlexWaygood
AlexWaygood requested review from hugovk and rhettinger May 25, 2023 12:42
hugovk
hugovk approved these changes May 25, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels May 25, 2023
@AlexWaygood
AlexWaygood merged commit 38539ef into python:main May 25, 2023
@miss-islington

miss-islington commented May 25, 2023

Copy link
Copy Markdown
Contributor

Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label May 25, 2023
@AlexWaygood
AlexWaygood deleted the attrdict branch May 25, 2023 13:05
@bedevere-bot

bedevere-bot commented May 25, 2023

Copy link
Copy Markdown

GH-104931 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label May 25, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 25, 2023
@AlexWaygood @miss-islington
Fix indentation in json.AttrDict REPL example (pythonGH-104930)
284e81b 
This is causing the docs to be rendered incorrectly.
(cherry picked from commit 38539ef)

Co-authored-by: Alex Waygood <[email protected]>
AlexWaygood added a commit that referenced this pull request May 25, 2023
@miss-islington @AlexWaygood
[3.12] Fix indentation in json.AttrDict REPL example (GH-104930) (#…
b328ba1 
…104931)

Fix indentation in `json.AttrDict` REPL example (GH-104930)

This is causing the docs to be rendered incorrectly.
(cherry picked from commit 38539ef)

Co-authored-by: Alex Waygood <[email protected]>
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
3.12 backport gh 105236 #105358
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes
@rhettinger rhettinger Awaiting requested review from rhettinger

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@AlexWaygood @miss-islington @bedevere-bot @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.