GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-104935: typing: Fix interactions between @runtime_checkable and Generic by JelleZijlstra · Pull Request #104939 · python/cpython

Conversation

@JelleZijlstra

@JelleZijlstra JelleZijlstra commented May 25, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Runtime-checkable protocols are broken on py312 (the sequel) #104935

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JelleZijlstra
pythongh-104935: Add back typing.Generic._is_protocol
2c3c428
@JelleZijlstra JelleZijlstra added topic-typing needs backport to 3.12 only security fixes labels May 25, 2023
@JelleZijlstra
JelleZijlstra requested review from AlexWaygood, Fidget-Spinner, gvanrossum and markshannon as code owners May 25, 2023 15:51
@bedevere-bot bedevere-bot added the awaiting core review label May 25, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 25, 2023
Runtime-checkable protocols are broken on py312 (the sequel) #104935
Closed
AlexWaygood
AlexWaygood reviewed May 25, 2023
View reviewed changes
Comment thread Lib/test/test_typing.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Objects/typevarobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra
Improve tests
a61816b
AlexWaygood
AlexWaygood reviewed May 25, 2023
View reviewed changes
Comment thread Lib/test/test_typing.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
JelleZijlstra and others added 3 commits May 25, 2023 09:12
@JelleZijlstra @AlexWaygood
Update Lib/test/test_typing.py
19bbcb0 
Co-authored-by: Alex Waygood <[email protected]>
@JelleZijlstra
Better approach
f299fbd
@JelleZijlstra
Update news
0859dcd
@JelleZijlstra JelleZijlstra changed the title gh-104935: Add back typing.Generic._is_protocol gh-104935: typing: Fix interactions between @runtime_checkable and Generic May 25, 2023
@AlexWaygood
AlexWaygood removed the request for review from markshannon May 25, 2023 16:22
AlexWaygood
AlexWaygood approved these changes May 25, 2023
View reviewed changes

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels May 25, 2023
@AlexWaygood
AlexWaygood enabled auto-merge (squash) May 25, 2023 16:23
@AlexWaygood
AlexWaygood merged commit 2b7027d into python:main May 25, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label May 25, 2023
@miss-islington

miss-islington commented May 25, 2023

Copy link
Copy Markdown
Contributor

Thanks @JelleZijlstra for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented May 25, 2023

Copy link
Copy Markdown
Contributor

Sorry @JelleZijlstra and @AlexWaygood, I had trouble checking out the 3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 2b7027d0b2ee2e102a24a0da27d01b8221f9351c 3.12
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned AlexWaygood May 25, 2023
@AlexWaygood AlexWaygood added needs backport to 3.12 only security fixes and removed needs backport to 3.12 only security fixes labels May 25, 2023
@miss-islington

miss-islington commented May 25, 2023

Copy link
Copy Markdown
Contributor

Thanks @JelleZijlstra for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra JelleZijlstra removed the needs backport to 3.12 only security fixes label May 25, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 25, 2023
@JelleZijlstra @AlexWaygood @miss-islington
pythongh-104935: typing: Fix interactions between `@runtime_checkable…
f67a992 
…` and `Generic` (pythonGH-104939)

---------

(cherry picked from commit 2b7027d)

Co-authored-by: Jelle Zijlstra <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
@bedevere-bot

bedevere-bot commented May 25, 2023

Copy link
Copy Markdown

GH-104941 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra JelleZijlstra added the needs backport to 3.12 only security fixes label May 25, 2023
@miss-islington

miss-islington commented May 25, 2023

Copy link
Copy Markdown
Contributor

Thanks @JelleZijlstra for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra
JelleZijlstra deleted the is_protocol branch May 25, 2023 16:44
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 25, 2023
@JelleZijlstra @AlexWaygood @miss-islington
pythongh-104935: typing: Fix interactions between `@runtime_checkable…
70cc4e5 
…` and `Generic` (pythonGH-104939)

---------

(cherry picked from commit 2b7027d)

Co-authored-by: Jelle Zijlstra <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
@JelleZijlstra

JelleZijlstra commented May 25, 2023

Copy link
Copy Markdown
Member Author

oops
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood

AlexWaygood commented May 25, 2023

Copy link
Copy Markdown
Member

Yeah you made @miss-islington force-push to her PR branch!
JelleZijlstra reacted with confused emoji
All reactions
  • 😕 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AlexWaygood added a commit that referenced this pull request May 25, 2023
@miss-islington @JelleZijlstra @AlexWaygood
[3.12] gh-104935: typing: Fix interactions between `@runtime_checkabl…
930efde 
…e` and `Generic` (GH-104939) (#104941)

gh-104935: typing: Fix interactions between `@runtime_checkable` and `Generic` (GH-104939)

---------

(cherry picked from commit 2b7027d)

Co-authored-by: Jelle Zijlstra <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
3.12 backport gh 105236 #105358
Closed
@JelleZijlstra
JelleZijlstra restored the is_protocol branch September 10, 2024 23:37
@ZeroIntensity ZeroIntensity removed the needs backport to 3.12 only security fixes label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes
@gvanrossum gvanrossum Awaiting requested review from gvanrossum
@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@AlexWaygood AlexWaygood

Labels

topic-typing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@JelleZijlstra @miss-islington @bedevere-bot @AlexWaygood @ZeroIntensity
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.