GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-104947: Make pathlib.PureWindowsPath comparisons consistent across platforms by barneygale · Pull Request #104948 · python/cpython

Conversation

@barneygale

@barneygale barneygale commented May 25, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Use str.lower() rather than ntpath.normcase() to normalize case of Windows paths. This restores behaviour from Python 3.11.

  • Issue: pathlib.PureWindowsPath comparison results vary between Windows and Posix #104947

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@barneygale
Add failing test.
501c06d
@barneygale barneygale added topic-pathlib needs backport to 3.12 only security fixes labels May 25, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 25, 2023
pathlib.PureWindowsPath comparison results vary between Windows and Posix #104947
Closed
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label May 25, 2023
@barneygale
pythonGH-104947: Make pathlib.PureWindowsPath comparisons consistent …
256e1ee 
…across OSs

Use `str.lower()` rather than `ntpath.normcase()` to normalize case of
Windows paths. This restores behaviour from Python 3.11.
@barneygale barneygale changed the title [WIP] GH-104947: Make pathlib.PureWindowsPath comparisons consistent across platforms GH-104947: Make pathlib.PureWindowsPath comparisons consistent across platforms May 25, 2023
@barneygale
barneygale marked this pull request as ready for review May 25, 2023 22:44
@bedevere-bot bedevere-bot added the awaiting core review label May 25, 2023
@barneygale barneygale removed the tests Tests in the Lib/test dir label May 25, 2023
gpshead
gpshead approved these changes May 26, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels May 26, 2023
@gpshead
mention this matches 3.11 behavior in the news entry.
9327012
@barneygale
barneygale enabled auto-merge (squash) May 26, 2023 17:42
@barneygale
barneygale merged commit ad0be36 into python:main May 26, 2023
@miss-islington

miss-islington commented May 26, 2023

Copy link
Copy Markdown
Contributor

Thanks @barneygale for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label May 26, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 26, 2023
@barneygale @gpshead @miss-islington
pythonGH-104947: Make pathlib.PureWindowsPath comparisons consistent …
0b5ccbb 
…across platforms (pythonGH-104948)

Use `str.lower()` rather than `ntpath.normcase()` to normalize case of
Windows paths. This restores behaviour from Python 3.11.

(cherry picked from commit ad0be36)

Co-authored-by: Barney Gale <[email protected]>
Co-authored-by: Gregory P. Smith <[email protected]>
@bedevere-bot

bedevere-bot commented May 26, 2023

Copy link
Copy Markdown

GH-104990 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label May 26, 2023
barneygale added a commit that referenced this pull request May 26, 2023
@miss-islington @barneygale @gpshead
[3.12] GH-104947: Make pathlib.PureWindowsPath comparisons consistent…
eca102d 
… across platforms (GH-104948) (GH-104990)

Use `str.lower()` rather than `ntpath.normcase()` to normalize case of
Windows paths. This restores behaviour from Python 3.11.

(cherry picked from commit ad0be36)

Co-authored-by: Barney Gale <[email protected]>
Co-authored-by: Gregory P. Smith <[email protected]>
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
3.12 backport gh 105236 #105358
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

topic-pathlib

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@barneygale @miss-islington @bedevere-bot @gpshead
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.