GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Remove raw asserts in test_typing.py by JelleZijlstra · Pull Request #104951 · python/cpython

Conversation

@JelleZijlstra

@JelleZijlstra JelleZijlstra commented May 26, 2023

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JelleZijlstra
Remove raw asserts in test_typing.py
33be00c
@JelleZijlstra JelleZijlstra added skip issue skip news needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels May 26, 2023
@JelleZijlstra
JelleZijlstra requested review from AlexWaygood, Fidget-Spinner and gvanrossum as code owners May 26, 2023 02:55
@bedevere-bot bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels May 26, 2023
Fidget-Spinner
Fidget-Spinner approved these changes May 26, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels May 26, 2023
AlexWaygood
AlexWaygood reviewed May 26, 2023
View reviewed changes
Comment thread Lib/test/test_typing.py
Comment on lines +7107 to +7108
self.assertEqual(Point2Dor3D.__required_keys__, frozenset(['x', 'y']))
self.assertEqual(Point2Dor3D.__optional_keys__, frozenset(['z']))

@AlexWaygood AlexWaygood May 26, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in this PR look good. But it looks like we have a lot of tests in this test class that do things like self.assertEqual(some_frozenset, frozenset(['x', 'y'])). That looks like it's checking that some_frozenset is a frozenset, but it's actually not, because frozensets and sets with the same members compare equal. So I wonder if we should be doing this:

Suggested change
self.assertEqual(Point2Dor3D.__required_keys__, frozenset(['x', 'y']))
self.assertEqual(Point2Dor3D.__optional_keys__, frozenset(['z']))
self.assertEqual(Point2Dor3D.__required_keys__, {'x', 'y'})
self.assertIsInstance(Point2Dor3D.__required_keys__, frozenset)
self.assertEqual(Point2Dor3D.__optional_keys__, {'z'})
self.assertIsInstance(Point2Dor3D.__optional_keys__, frozenset)

But maybe we don't need to assert the type of __required_keys__ every time we want to check the contents of the set.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@AlexWaygood AlexWaygood May 26, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway, we don't need to change that in this PR; the changes here are definitely good.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@JelleZijlstra JelleZijlstra May 26, 2023

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well do that in this PR too.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@JelleZijlstra JelleZijlstra May 26, 2023

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed a few new asserts checking that it's really a frozenset

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AlexWaygood reacted with hooray emoji
All reactions
  • 🎉 1 reaction
AlexWaygood
AlexWaygood approved these changes May 26, 2023
View reviewed changes
JelleZijlstra added 2 commits May 26, 2023 05:49
@JelleZijlstra
Add some checks that required/optional keys is really a frozenset
f76b460
@JelleZijlstra
Merge remote-tracking branch 'upstream/main' into rawassert
c054021
AlexWaygood
AlexWaygood approved these changes May 26, 2023
View reviewed changes

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AlexWaygood
AlexWaygood merged commit 2cb4456 into python:main May 26, 2023
@miss-islington

miss-islington commented May 26, 2023

Copy link
Copy Markdown
Contributor

Thanks @JelleZijlstra for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label May 26, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 26, 2023
@JelleZijlstra @miss-islington
Remove raw asserts in test_typing.py (pythonGH-104951)
2715dc4 
(cherry picked from commit 2cb4456)

Co-authored-by: Jelle Zijlstra <[email protected]>
@bedevere-bot

bedevere-bot commented May 26, 2023

Copy link
Copy Markdown

GH-104978 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label May 26, 2023
@bedevere-bot

bedevere-bot commented May 26, 2023

Copy link
Copy Markdown

GH-104979 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label May 26, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 26, 2023
@JelleZijlstra @miss-islington
Remove raw asserts in test_typing.py (pythonGH-104951)
d37ef60 
(cherry picked from commit 2cb4456)

Co-authored-by: Jelle Zijlstra <[email protected]>
AlexWaygood pushed a commit that referenced this pull request May 26, 2023
@miss-islington @JelleZijlstra
[3.11] Remove raw asserts in test_typing.py (GH-104951) (#104979)
ca55247 
Remove raw asserts in test_typing.py (GH-104951)
(cherry picked from commit 2cb4456)

Co-authored-by: Jelle Zijlstra <[email protected]>
AlexWaygood pushed a commit that referenced this pull request May 26, 2023
@miss-islington @JelleZijlstra
[3.12] Remove raw asserts in test_typing.py (GH-104951) (#104978)
01af2b0 
Remove raw asserts in test_typing.py (GH-104951)
(cherry picked from commit 2cb4456)

Co-authored-by: Jelle Zijlstra <[email protected]>
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
3.12 backport gh 105236 #105358
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes
@AlexWaygood AlexWaygood AlexWaygood approved these changes
@gvanrossum gvanrossum Awaiting requested review from gvanrossum

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip issue skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@JelleZijlstra @miss-islington @bedevere-bot @Fidget-Spinner @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.