GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-104955: Fix __release_buffer__ signature by JelleZijlstra · Pull Request #104956 · python/cpython

Conversation

@JelleZijlstra

@JelleZijlstra JelleZijlstra commented May 26, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Fixes #104955

  • Issue: Signature for __release_buffer__ is incorrect #104955

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@JelleZijlstra
pythongh-104955: Fix __release_buffer__ signature
74617c7
@JelleZijlstra JelleZijlstra added the needs backport to 3.12 only security fixes label May 26, 2023
@JelleZijlstra
JelleZijlstra requested a review from markshannon as a code owner May 26, 2023 04:49
@bedevere-bot bedevere-bot added the awaiting core review label May 26, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 26, 2023
Signature for __release_buffer__ is incorrect #104955
Closed
kumaraditya303
kumaraditya303 approved these changes May 26, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels May 26, 2023
kumaraditya303
kumaraditya303 reviewed May 26, 2023
View reviewed changes
Comment thread Misc/NEWS.d/next/Core and Builtins/2023-05-25-21-40-39.gh-issue-104955.LZx7jf.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

@JelleZijlstra @kumaraditya303
Update Misc/NEWS.d/next/Core and Builtins/2023-05-25-21-40-39.gh-issu…
3c5d2cf
…e-104955.LZx7jf.rst

Co-authored-by: Kumar Aditya <[email protected]>
@JelleZijlstra
JelleZijlstra merged commit 6e1eccd into python:main May 26, 2023
@miss-islington

miss-islington commented May 26, 2023

Copy link
Copy Markdown
Contributor

Thanks @JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the awaiting merge label May 26, 2023
@JelleZijlstra
JelleZijlstra deleted the releasebufsig branch May 26, 2023 12:44
@bedevere-bot

bedevere-bot commented May 26, 2023

Copy link
Copy Markdown

GH-104973 is a backport of this pull request to the 3.12 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 26, 2023
@JelleZijlstra @kumaraditya303 @miss-islington
pythongh-104955: Fix __release_buffer__ signature (pythonGH-104956)
5a9c46e
(cherry picked from commit 6e1eccd)

Co-authored-by: Jelle Zijlstra <[email protected]>
Co-authored-by: Kumar Aditya <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label May 26, 2023
JelleZijlstra added a commit that referenced this pull request May 26, 2023
@miss-islington @JelleZijlstra @kumaraditya303
[3.12] gh-104955: Fix __release_buffer__ signature (GH-104956) (#104973)
3158b4d
(cherry picked from commit 6e1eccd)

Co-authored-by: Jelle Zijlstra <[email protected]>
Co-authored-by: Kumar Aditya <[email protected]>
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
3.12 backport gh 105236 #105358
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Signature for __release_buffer__ is incorrect

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@JelleZijlstra @miss-islington @bedevere-bot @kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.